Fix: return landingpage url #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems there is an bug in the code which causes issues if you use the store code in the url and don't use ajax. I will fix this |
|
Fixed the bug. @jansentjeu This is ready to be tested. |
jansentjeu
requested changes
Jul 26, 2024
jansentjeu
requested changes
Sep 13, 2024
This reverts commit b1d986b.
jansentjeu
approved these changes
Sep 13, 2024
ah-net
added a commit
that referenced
this pull request
Sep 24, 2024
commit 6c59807 Merge: b087d6f 27b6967 Author: ah-net <103565001+ah-net@users.noreply.github.com> Date: Tue Sep 24 14:39:53 2024 +0200 Merge branch 'master' into beta commit b087d6f Merge: a63f1b7 cb61179 Author: ah-net <103565001+ah-net@users.noreply.github.com> Date: Thu Sep 19 11:36:00 2024 +0200 Merge pull request #33 from EmicoEcommerce/fix-bump-php-version Fix: bump php version commit cb61179 Author: ah-net <103565001+ah-net@users.noreply.github.com> Date: Thu Sep 19 11:15:24 2024 +0200 fix: bump php version commit a63f1b7 Merge: 7ce708c 15b7a61 Author: ah-net <103565001+ah-net@users.noreply.github.com> Date: Thu Sep 19 10:55:54 2024 +0200 Merge pull request #31 from EmicoEcommerce/fix-return-landingpage-url Fix: return landingpage url commit 7ce708c Merge: 69e0406 37a9fef Author: ah-net <103565001+ah-net@users.noreply.github.com> Date: Thu Sep 19 10:46:29 2024 +0200 Merge pull request #32 from EmicoEcommerce/fix-select-attribute fix: selecting attribute doesn't update commit 37a9fef Author: ah-net <103565001+ah-net@users.noreply.github.com> Date: Tue Sep 17 10:46:38 2024 +0200 fix: selecting attribute commit 15b7a61 Author: ah-net <103565001+ah-net@users.noreply.github.com> Date: Fri Sep 13 13:18:12 2024 +0200 Revert "Update RendererPlugin.php" This reverts commit b1d986b. commit b1d986b Author: ah-net <103565001+ah-net@users.noreply.github.com> Date: Fri Sep 13 13:02:54 2024 +0200 Update RendererPlugin.php commit 9bd57b4 Author: ah-net <103565001+ah-net@users.noreply.github.com> Date: Thu Jun 27 10:04:04 2024 +0200 Remove space commit ce621b2 Author: ah-net <103565001+ah-net@users.noreply.github.com> Date: Thu Jun 27 10:01:38 2024 +0200 Fix bug without ajax commit d50ae96 Author: ah-net <103565001+ah-net@users.noreply.github.com> Date: Fri Jun 21 11:10:43 2024 +0200 fix: landing page url commit 8bc79ac Author: ah-net <103565001+ah-net@users.noreply.github.com> Date: Thu Jun 20 10:14:35 2024 +0200 fix: bug with landingpage url commit 69e0406 Author: evs-xsarus <44158071+evs-xsarus@users.noreply.github.com> Date: Tue Apr 30 15:58:23 2024 +0200 Make installable on PHP 8.x (#24) * fix: make installable on php 8.3 commit 9ac763e Author: ah-net <103565001+ah-net@users.noreply.github.com> Date: Tue Apr 30 15:42:25 2024 +0200 fix: save tweakwise filter template commit 103be57 Author: ah-net <103565001+ah-net@users.noreply.github.com> Date: Tue Apr 30 15:41:50 2024 +0200 chore: update version (#28) * chore: update version * chore: remove composer version * chore: support tweakwise 6.0 * chore: support version 5.0 of attribute landing
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you use an landingpage for an filter, and use the same url for the landingpage the returned url is not correct. This pull request fixes that.
For example. If you have an ALP configured for the category shoes. With the filter brand = nike. And you make the url of the landingpage /shoes/brand/nike
This causes the url of the page to be incorrect after selecting nike on the brand filter (category shoes). And if you select 2 filters it's impossible to disable the first filter.
How to test