This repository was archived by the owner on Oct 19, 2022. It is now read-only.
Php8.1 #130
Merged
Php8.1 #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramstroker
reviewed
Jun 22, 2022
| @@ -266,7 +266,11 @@ protected function scalarValue($value) | |||
| $value = $this->normalizeExponent($value); | |||
| } | |||
|
|
|||
| return html_entity_decode($value, ENT_NOQUOTES | ENT_HTML5); | |||
| if (!empty($value)) { | |||
There was a problem hiding this comment.
@ah-net I think this change causes another regression we had in our shop with 4.2.0, where almost all our products were exported with <stock/> instead of <stock>0</stock> causing the feed to not be validated correctly.
0 is also empty.
There was a problem hiding this comment.
Your right. Ill make an pull request
There was a problem hiding this comment.
Made an pull request #134
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #129