perf: Applied phpcs and phpmd rules #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Code is refactored based on phpcs and phpmd rules.
# Conflicts: # phpcs.xml
BREAKING CHANGE: Code is refactored based on phpcs and phpmd rules.
…perf/TW-13-grumphp-issues
ah-net
added a commit
that referenced
this pull request
Apr 10, 2024
* chore: Added semantic release (#30) * chore: Added semantic release * chore: Added develop branch to semantic release * chore: Set beta branch as prerelease branch * chore: Only trigger release workflow for master and beta branch * chore: Updated README for semantic release * chore: Added Youwe Testing Suite * chore: Added Magento secrets in testing suite action * chore: Disabled phpstan linter * chore: Fixed phpmd linter * chore: Run grumphp directly with PHP * fix: use id instead of SKU (#39) Use entity_id in the WHERE clause instead of sku. This adjustment enhances the query's speed, especially when dealing with a large number of products. During local testing, the export time decreased significantly from 50 minutes to just 8 minutes. Resulting in an increase in speed of 84%. This speed increase only seems to occur if you don't have all numbers as sku's. * chore(release): 6.0.3-beta.1 [skip ci] ## [6.0.3-beta.1](v6.0.2...v6.0.3-beta.1) (2024-03-29) ### Bug Fixes * use id instead of SKU ([#39](#39)) ([7b325cb](7b325cb)) * perf: Applied phpcs and phpmd rules BREAKING CHANGE: Code is refactored based on phpcs and phpmd rules. * fix: Fixed DriverInterface issue * chore(release): 7.0.0-beta.1 [skip ci] # [7.0.0-beta.1](v6.0.2...v7.0.0-beta.1) (2024-03-29) ### Bug Fixes * Fixed DriverInterface issue ([a6d0109](a6d0109)) * use id instead of SKU ([#39](#39)) ([7b325cb](7b325cb)) ### Performance Improvements * Applied phpcs and phpmd rules ([d7e82dd](d7e82dd)) ### BREAKING CHANGES * Code is refactored based on phpcs and phpmd rules. * fix: Fixed issue in FeedContent construct * chore(release): 7.0.0-beta.1 [skip ci] # [7.0.0-beta.1](v6.0.2...v7.0.0-beta.1) (2024-04-05) ### Bug Fixes * Fixed DriverInterface issue ([a6d0109](a6d0109)) * Fixed issue in FeedContent construct ([d289fd3](d289fd3)) * use id instead of SKU ([#39](#39)) ([7b325cb](7b325cb)) ### Performance Improvements * Applied phpcs and phpmd rules ([d7e82dd](d7e82dd)) ### BREAKING CHANGES * Code is refactored based on phpcs and phpmd rules. * chore: Changed release job permissions * chore(release): 7.0.0-beta.1 [skip ci] # [7.0.0-beta.1](v6.0.2...v7.0.0-beta.1) (2024-04-05) ### Bug Fixes * Fixed DriverInterface issue ([a6d0109](a6d0109)) * Fixed issue in FeedContent construct ([d289fd3](d289fd3)) * use id instead of SKU ([#39](#39)) ([7b325cb](7b325cb)) ### Performance Improvements * Applied phpcs and phpmd rules ([d7e82dd](d7e82dd)) ### BREAKING CHANGES * Code is refactored based on phpcs and phpmd rules. * Bump version nr * chore(release): 7.0.0-beta.1 [skip ci] # [7.0.0-beta.1](v6.0.2...v7.0.0-beta.1) (2024-04-09) ### Bug Fixes * Fixed DriverInterface issue ([a6d0109](a6d0109)) * Fixed issue in FeedContent construct ([d289fd3](d289fd3)) * use id instead of SKU ([#39](#39)) ([7b325cb](7b325cb)) ### Performance Improvements * Applied phpcs and phpmd rules ([d7e82dd](d7e82dd)) ### BREAKING CHANGES * Code is refactored based on phpcs and phpmd rules. * fix: use id instead of SKU (#39) Use entity_id in the WHERE clause instead of sku. This adjustment enhances the query's speed, especially when dealing with a large number of products. During local testing, the export time decreased significantly from 50 minutes to just 8 minutes. Resulting in an increase in speed of 84%. This speed increase only seems to occur if you don't have all numbers as sku's. * chore(release): 7.0.0-beta.1 [skip ci] # [7.0.0-beta.1](v6.0.2...v7.0.0-beta.1) (2024-04-09) ### Bug Fixes * Fixed DriverInterface issue ([a6d0109](a6d0109)) * Fixed issue in FeedContent construct ([d289fd3](d289fd3)) * use id instead of SKU ([#39](#39)) ([389dad7](389dad7)) * use id instead of SKU ([#39](#39)) ([7b325cb](7b325cb)) ### Performance Improvements * Applied phpcs and phpmd rules ([d7e82dd](d7e82dd)) ### BREAKING CHANGES * Code is refactored based on phpcs and phpmd rules. * fix: use id instead of SKU #39 Use entity_id in the WHERE clause instead of sku. This adjustment enhances the query's speed, especially when dealing with a large number of products. During local testing, the export time decreased significantly from 50 minutes to just 8 minutes. Resulting in an increase in speed of 84%. This speed increase only seems to occur if you don't have all numbers as sku's. * chore(release): 7.0.0-beta.2 [skip ci] # [7.0.0-beta.2](v7.0.0-beta.1...v7.0.0-beta.2) (2024-04-09) ### Bug Fixes * use id instead of SKU [#39](#39) ([3576069](3576069)) * perf: Applied phpcs and phpmd rules BREAKING CHANGE: Code is refactored based on phpcs and phpmd rules. #37 #36 * fix: use id instead of sku #39 Use entity_id in the WHERE clause instead of sku. This adjustment enhances the query's speed, especially when dealing with a large number of products. During local testing, the export time decreased significantly from 50 minutes to just 8 minutes. Resulting in an increase in speed of 84%. This speed increase only seems to occur if you don't have all numbers as sku's. * chore(release): 7.0.0-beta.3 [skip ci] # [7.0.0-beta.3](v7.0.0-beta.2...v7.0.0-beta.3) (2024-04-10) ### Bug Fixes * use id instead of sku [#39](#39) ([7f8fa8a](7f8fa8a)) ### Performance Improvements * Applied phpcs and phpmd rules ([dad3813](dad3813)) ### BREAKING CHANGES * Code is refactored based on phpcs and phpmd rules. #37 #36 --------- Co-authored-by: Tjeu Jansen <161043478+jansentjeu@users.noreply.github.com> Co-authored-by: tjeujansen <tjansen@emico.nl> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
Merged
github-actions bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
# [7.0.0-beta.1](v6.0.2...v7.0.0-beta.1) (2024-04-10) ### Bug Fixes * Applied phpcs and phpmd rules [#38](#38) ([b63a1cc](b63a1cc)) * use id instead of SKU [#39](#39) ([76d45bf](76d45bf)) * Merge beta into master (#45) ([12701f7](12701f7)), closes [#45](#45) [#30](#30) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#37](#37) [#36](#36) ### BREAKING CHANGES * Code is refactored based on phpcs and phpmd rules. * Code is refactored based on phpcs and phpmd rules. * fix: Fixed DriverInterface issue * chore(release): 7.0.0-beta.1 [skip ci] # [7.0.0-beta.1](v6.0.2...v7.0.0-beta.1) (2024-03-29) ### Bug Fixes * Fixed DriverInterface issue ([a6d0109](a6d0109)) * Code is refactored based on phpcs and phpmd rules. #37 #36
ah-net
pushed a commit
that referenced
this pull request
Apr 10, 2024
# [7.0.0-beta.1](v6.0.2...v7.0.0-beta.1) (2024-04-10) ### Bug Fixes * Applied phpcs and phpmd rules [#38](#38) ([b63a1cc](b63a1cc)) * use id instead of SKU [#39](#39) ([76d45bf](76d45bf)) * Merge beta into master (#45) ([12701f7](12701f7)), closes [#45](#45) [#30](#30) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#37](#37) [#36](#36) ### BREAKING CHANGES * Code is refactored based on phpcs and phpmd rules. * Code is refactored based on phpcs and phpmd rules. * fix: Fixed DriverInterface issue * chore(release): 7.0.0-beta.1 [skip ci] # [7.0.0-beta.1](v6.0.2...v7.0.0-beta.1) (2024-03-29) ### Bug Fixes * Fixed DriverInterface issue ([a6d0109](a6d0109)) * Code is refactored based on phpcs and phpmd rules. #37 #36
github-actions bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
# [7.0.0-beta.1](v6.0.2...v7.0.0-beta.1) (2024-04-10) ### Bug Fixes * Applied phpcs and phpmd rules [#38](#38) ([e3966fd](e3966fd)) * Trigger release ([ed7cc19](ed7cc19)) * use id instead of SKU [#39](#39) ([f0070ec](f0070ec)) * Merge beta into master (#45) ([12701f7](12701f7)), closes [#45](#45) [#30](#30) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#37](#37) [#36](#36) ### BREAKING CHANGES * Code is refactored based on phpcs and phpmd rules. * Code is refactored based on phpcs and phpmd rules. * Code is refactored based on phpcs and phpmd rules. * fix: Fixed DriverInterface issue * chore(release): 7.0.0-beta.1 [skip ci] # [7.0.0-beta.1](v6.0.2...v7.0.0-beta.1) (2024-03-29) ### Bug Fixes * Fixed DriverInterface issue ([a6d0109](a6d0109)) * Code is refactored based on phpcs and phpmd rules. #37 #36
jansentjeu
pushed a commit
that referenced
this pull request
Apr 10, 2024
# [7.0.0-beta.1](v6.0.2...v7.0.0-beta.1) (2024-04-10) ### Bug Fixes * Applied phpcs and phpmd rules [#38](#38) ([e3966fd](e3966fd)) * Trigger release ([ed7cc19](ed7cc19)) * use id instead of SKU [#39](#39) ([f0070ec](f0070ec)) * Merge beta into master (#45) ([12701f7](12701f7)), closes [#45](#45) [#30](#30) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#37](#37) [#36](#36) ### BREAKING CHANGES * Code is refactored based on phpcs and phpmd rules. * Code is refactored based on phpcs and phpmd rules. * Code is refactored based on phpcs and phpmd rules. * fix: Fixed DriverInterface issue * chore(release): 7.0.0-beta.1 [skip ci] # [7.0.0-beta.1](v6.0.2...v7.0.0-beta.1) (2024-03-29) ### Bug Fixes * Fixed DriverInterface issue ([a6d0109](a6d0109)) * Code is refactored based on phpcs and phpmd rules. #37 #36
github-actions bot
pushed a commit
that referenced
this pull request
Apr 12, 2024
# [7.0.0-beta.1](v6.0.2...v7.0.0-beta.1) (2024-04-12) ### Bug Fixes * Applied phpcs and phpmd rules [#38](#38) ([e3966fd](e3966fd)) * Trigger release ([7334c1e](7334c1e)) * use id instead of SKU [#39](#39) ([f0070ec](f0070ec)) * Merge beta into master (#45) ([12701f7](12701f7)), closes [#45](#45) [#30](#30) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#37](#37) [#36](#36) ### BREAKING CHANGES * Code is refactored based on phpcs and phpmd rules. * Code is refactored based on phpcs and phpmd rules. * Code is refactored based on phpcs and phpmd rules. * fix: Fixed DriverInterface issue * chore(release): 7.0.0-beta.1 [skip ci] # [7.0.0-beta.1](v6.0.2...v7.0.0-beta.1) (2024-03-29) ### Bug Fixes * Fixed DriverInterface issue ([a6d0109](a6d0109)) * Code is refactored based on phpcs and phpmd rules. #37 #36
ah-net
pushed a commit
that referenced
this pull request
Apr 12, 2024
# [7.0.0-beta.1](v6.0.2...v7.0.0-beta.1) (2024-04-12) ### Bug Fixes * Applied phpcs and phpmd rules [#38](#38) ([e3966fd](e3966fd)) * Trigger release ([7334c1e](7334c1e)) * use id instead of SKU [#39](#39) ([f0070ec](f0070ec)) * Merge beta into master (#45) ([12701f7](12701f7)), closes [#45](#45) [#30](#30) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#37](#37) [#36](#36) ### BREAKING CHANGES * Code is refactored based on phpcs and phpmd rules. * Code is refactored based on phpcs and phpmd rules. * Code is refactored based on phpcs and phpmd rules. * fix: Fixed DriverInterface issue * chore(release): 7.0.0-beta.1 [skip ci] # [7.0.0-beta.1](v6.0.2...v7.0.0-beta.1) (2024-03-29) ### Bug Fixes * Fixed DriverInterface issue ([a6d0109](a6d0109)) * Code is refactored based on phpcs and phpmd rules. #37 #36
github-actions bot
pushed a commit
that referenced
this pull request
Apr 12, 2024
# [7.0.0-beta.1](v6.0.2...v7.0.0-beta.1) (2024-04-12) ### Bug Fixes * Applied phpcs and phpmd rules [#38](#38) ([e3966fd](e3966fd)) * Trigger release ([7334c1e](7334c1e)) * use id instead of SKU [#39](#39) ([f0070ec](f0070ec)) * Merge beta into master (#45) ([12701f7](12701f7)), closes [#45](#45) [#30](#30) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#37](#37) [#36](#36) ### BREAKING CHANGES * Code is refactored based on phpcs and phpmd rules. * Code is refactored based on phpcs and phpmd rules. * Code is refactored based on phpcs and phpmd rules. * fix: Fixed DriverInterface issue * chore(release): 7.0.0-beta.1 [skip ci] # [7.0.0-beta.1](v6.0.2...v7.0.0-beta.1) (2024-03-29) ### Bug Fixes * Fixed DriverInterface issue ([a6d0109](a6d0109)) * Code is refactored based on phpcs and phpmd rules. #37 #36
github-actions bot
pushed a commit
that referenced
this pull request
Apr 12, 2024
# [7.0.0-beta.1](v6.0.2...v7.0.0-beta.1) (2024-04-12) ### Bug Fixes * Applied phpcs and phpmd rules [#38](#38) ([e3966fd](e3966fd)) * Trigger release ([7334c1e](7334c1e)) * use id instead of SKU [#39](#39) ([f0070ec](f0070ec)) * Merge beta into master (#45) ([12701f7](12701f7)), closes [#45](#45) [#30](#30) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#37](#37) [#36](#36) ### BREAKING CHANGES * Code is refactored based on phpcs and phpmd rules. * Code is refactored based on phpcs and phpmd rules. * Code is refactored based on phpcs and phpmd rules. * fix: Fixed DriverInterface issue * chore(release): 7.0.0-beta.1 [skip ci] # [7.0.0-beta.1](v6.0.2...v7.0.0-beta.1) (2024-03-29) ### Bug Fixes * Fixed DriverInterface issue ([a6d0109](a6d0109)) * Code is refactored based on phpcs and phpmd rules. #37 #36
ah-net
added a commit
that referenced
this pull request
Apr 12, 2024
* chore: manually trigger release * Trigger release manually (#56) * chore: manually trigger release * Update release.yml * chore(release): 7.0.0-beta.1 [skip ci] # [7.0.0-beta.1](v6.0.2...v7.0.0-beta.1) (2024-04-12) ### Bug Fixes * Applied phpcs and phpmd rules [#38](#38) ([e3966fd](e3966fd)) * Trigger release ([7334c1e](7334c1e)) * use id instead of SKU [#39](#39) ([f0070ec](f0070ec)) * Merge beta into master (#45) ([12701f7](12701f7)), closes [#45](#45) [#30](#30) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#37](#37) [#36](#36) ### BREAKING CHANGES * Code is refactored based on phpcs and phpmd rules. * Code is refactored based on phpcs and phpmd rules. * Code is refactored based on phpcs and phpmd rules. * fix: Fixed DriverInterface issue * chore(release): 7.0.0-beta.1 [skip ci] # [7.0.0-beta.1](v6.0.2...v7.0.0-beta.1) (2024-03-29) ### Bug Fixes * Fixed DriverInterface issue ([a6d0109](a6d0109)) * Code is refactored based on phpcs and phpmd rules. #37 #36 * chore(release): 7.0.0-beta.1 [skip ci] # [7.0.0-beta.1](v6.0.2...v7.0.0-beta.1) (2024-04-12) ### Bug Fixes * Applied phpcs and phpmd rules [#38](#38) ([e3966fd](e3966fd)) * Trigger release ([7334c1e](7334c1e)) * use id instead of SKU [#39](#39) ([f0070ec](f0070ec)) * Merge beta into master (#45) ([12701f7](12701f7)), closes [#45](#45) [#30](#30) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#37](#37) [#36](#36) ### BREAKING CHANGES * Code is refactored based on phpcs and phpmd rules. * Code is refactored based on phpcs and phpmd rules. * Code is refactored based on phpcs and phpmd rules. * fix: Fixed DriverInterface issue * chore(release): 7.0.0-beta.1 [skip ci] # [7.0.0-beta.1](v6.0.2...v7.0.0-beta.1) (2024-03-29) ### Bug Fixes * Fixed DriverInterface issue ([a6d0109](a6d0109)) * Code is refactored based on phpcs and phpmd rules. #37 #36 --------- Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
github-actions bot
pushed a commit
that referenced
this pull request
Apr 12, 2024
# [7.0.0](v6.0.2...v7.0.0) (2024-04-12) ### Bug Fixes * Applied phpcs and phpmd rules [#38](#38) ([e3966fd](e3966fd)) * Trigger release ([7334c1e](7334c1e)) * use id instead of SKU [#39](#39) ([f0070ec](f0070ec)) * Merge beta into master (#45) ([12701f7](12701f7)), closes [#45](#45) [#30](#30) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#37](#37) [#36](#36) ### BREAKING CHANGES * Code is refactored based on phpcs and phpmd rules. * Code is refactored based on phpcs and phpmd rules. * Code is refactored based on phpcs and phpmd rules. * fix: Fixed DriverInterface issue * chore(release): 7.0.0-beta.1 [skip ci] # [7.0.0-beta.1](v6.0.2...v7.0.0-beta.1) (2024-03-29) ### Bug Fixes * Fixed DriverInterface issue ([a6d0109](a6d0109)) * Code is refactored based on phpcs and phpmd rules. #37 #36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.