color picker grid #118 #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmaTellblom
requested changes
Oct 7, 2024
There was a problem hiding this comment.
I see that you removed Cyan from the dark theme colors. But there is still 25 colors for the light theme colors. My suggestion would be that we delete color white from the light theme and that we remove color black from dark theme colors. These colors will be hard to see on each theme anyways so it should be fine. Then we can keep cyan that is a color that shows well in dark theme.
carstenhag
reviewed
Oct 8, 2024
|
|
||
| val colorMap = DataSource(isDarkMode()).colorMap | ||
| val colorsPerColumn = colorMap.size / 3 | ||
| val colorColumns = listOf( |
There was a problem hiding this comment.
Use colorMap.chunked(colorsPerColumn) here.
EmmaTellblom
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added grid on color picker BUT removed one color so they fit. #118