New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harmonize dialogs, general cleanup #171

Merged

EmmaTellblom merged 3 commits into EmmaTellblom:main from carstenhag:feature/harmonize-dialogs

Nov 4, 2024

Collaborator

carstenhag commented Nov 3, 2024 •

edited

Loading

Fixes #120

Hardcoded paddings inside the dialogs got removed
Add modifier: Modifier = Modifier to public composables
Don't wrap Text in Column if not necessary (inside AlertDialog)
Early abort method to avoid indentation levels
Add compose previews where possible (when dbHelper is used, it won't work...)
Use Card with onClick and not Modifier.clickable(), else the ripple animation is wrong

Screenshots:

carstenhag added 3 commits

November 3, 2024 20:55


          Harmonize dialogs. Fix file/method naming. General cleanup

5591d08


          Fix ripple animation being wrong on symptom item list

2afe6e4


          Remove unused imports/variables

88a5fb9

EmmaTellblom approved these changes

View reviewed changes

EmmaTellblom approved these changes

View reviewed changes

EmmaTellblom merged commit dd539b5 into EmmaTellblom:main

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet