Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Statistics screen, improve text formatting/style #201

Merged
merged 5 commits into from
Nov 30, 2024

Conversation

carstenhag
Copy link
Collaborator

@carstenhag carstenhag commented Nov 30, 2024

Overview of the fixes:

  • At CalculationsHelper the variables don't get saved now. Instead, they act as a getter (similar to a function). This had to be done, as otherwise new period dates or setting changes would not make calculations update
private val periodHistory
    get() = dbHelper.getSettingByKey("period_history")?.value?.toIntOrNull() ?: 5
  • Both texts now wrap if the texts are too big to fit on the screen (increase device font size to test this)
  • Make the second text (with the statistic value) bold - pending discussion at Discord

Discord_UKcWg3IOkq
studio64_VtGxeGryMc
studio64_pi7PJt5m4b

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
@carstenhag carstenhag marked this pull request as ready for review November 30, 2024 13:24
@EmmaTellblom EmmaTellblom merged commit 82c16db into EmmaTellblom:main Nov 30, 2024
2 checks passed
@carstenhag carstenhag deleted the bugfix/147-statistics branch December 3, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Statistics screen does not handle long texts/large fontsizes properly
2 participants