Peculiar diagnostic behavior for unnecessary-if

[shushtain]

It seems strange to me that:

if state.highlighter.group then
  vim.api.nvim_del_augroup_by_id(state.highlighter.group)
end

produces no warning, as expected, while:

if state.highlighter.group then
  vim.api.nvim_del_augroup_by_id(state.highlighter.group)
  state.highlighter.group = nil
end

produces Impossible 'if' statement: this condition is always falsy [unnecessary-if].

Is it emmylua trying too hard, or am I missing something? :)

[CppCXY]

If highlighter.group can’t find a definition, then stat highlight.group = nil will be treated as the only definition. Alternatively, you can disable this diagnostic.

[CppCXY]

Due to Lua’s dynamic nature, I can’t rely on require or any specific order to determine the actual definition of a field.

[shushtain]

I see. Thanks!

If I may add my humble opinion, I would prefer if the warning-level diagnostics would be provided for things that are definitely wrong instead of what is undefined. But I respect the possibility of having different philosophy for this LSP.

Switched from lua_ls mainly for the sheer speed of emmylua, so thank you for that!