Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Template Inheritance #10

Closed
EmranMR opened this issue Jul 3, 2023 · 1 comment
Closed

Implement Template Inheritance #10

EmranMR opened this issue Jul 3, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@EmranMR
Copy link
Owner

EmranMR commented Jul 3, 2023

Old fashion Laravel apps might be using Template Inheritance.

Add support for the following:
1.

@section('test)
     test
@show
  1. Support for @parent keyword inside @section
    • Might be a good idea to just add to the keyword rule as it will get the job done.
@EmranMR EmranMR added the enhancement New feature or request label Jul 3, 2023
@EmranMR
Copy link
Owner Author

EmranMR commented Sep 3, 2023

inline @section() proven to be difficult to implement.
❌ It conflicts with the "nested" @section directives. Parser throws an error looking for the closing directive.
Things tried:

  • standalone inlineSection rule definition
  • adding , to text and creating `@section($.text, $.text)
  • Changing precedence
  • targeting , as high precedence

Regardless you either get inlineSection or the nested both throwing an error. 😬

EmranMR added a commit that referenced this issue Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant