Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment fix #45

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Comment fix #45

merged 2 commits into from
Dec 6, 2023

Conversation

calebdw
Copy link
Contributor

@calebdw calebdw commented Dec 6, 2023

Fixes #44

I also moved the tests to be more consistent with other repos.

@EmranMR
Copy link
Owner

EmranMR commented Dec 6, 2023 •
edited
Loading

@calebdw Thank you for the pull request!
Regarding the comment you are right! text node is redundant, and your implementation makes more sense (also reduces noise)!
Also thanks for moving tests so it follows the consensus, I just went ahead with tree-sitter docs and randomly picked one from "corpus or test/corpus".

@EmranMR EmranMR merged commit 5875fb1 into EmranMR:main Dec 6, 2023
1 check passed
EmranMR added a commit that referenced this pull request Dec 6, 2023
@EmranMR
Removed the redundant stubs #45
01e5550
@calebdw
Copy link
Contributor Author

calebdw commented Dec 6, 2023

@EmranMR, being under test is usually more common because you can have highlight tests under test/hightlight and it keeps all the tests grouped together

@calebdw calebdw deleted the comment_fix branch December 6, 2023 14:33
@EmranMR EmranMR mentioned this pull request Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nothing should be injected inside comments
2 participants
@calebdw @EmranMR