Api test #73
Merged
Api test #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddeath
reviewed
Oct 14, 2018
| @@ -0,0 +1,22 @@ | |||
| import fetch from 'node-fetch' | |||
There was a problem hiding this comment.
Maybe I would use https://github.com/matthew-andrews/isomorphic-fetch and added it also to the index.js That way we would have same fetch everywhere. But on the other hand that will add some js to app bundles...
What do you think about this?
There was a problem hiding this comment.
Quick scouting seems to be for node-fetch instead of isomorphic-fetch. Check this issue: graffle-js/graffle#14
In general, I would prefer using native fetch when possible (unless we figure out it is missing in some older version of Android/iOS)
ddeath
approved these changes
Oct 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.