Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactors #330

Merged
merged 3 commits into from
Oct 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions src/backend/app/Models/AgentTicket.php

This file was deleted.

2 changes: 1 addition & 1 deletion src/backend/app/Models/Base/BaseModel.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
* logic and define interaction between entities.
* "Most" models will extend this base model.
*/
class BaseModel extends Model
abstract class BaseModel extends Model
{
protected $guarded = ['id'];
public static $rules = [];
Expand Down
2 changes: 1 addition & 1 deletion src/backend/app/Models/Base/BaseModelCore.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Only applies to very few common, high-level configuration entities in
* the entire MPM-instance like database and plugin configuration.
*/
class BaseModelCore extends Model
abstract class BaseModelCore extends Model
{
protected $guarded = ['id'];
public static $rules = [];
Expand Down
19 changes: 0 additions & 19 deletions src/backend/app/Models/CityCluster.php

This file was deleted.

3 changes: 2 additions & 1 deletion src/backend/app/Sms/Bongo.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

use App\Lib\ISmsProvider;
use App\Models\Sms;
use App\Models\SmsAndroidSetting;
use GuzzleHttp\Client;
use GuzzleHttp\Psr7\Query;
use Illuminate\Support\Facades\Log;
Expand Down Expand Up @@ -85,7 +86,7 @@ public function sendGetSms(string $number, string $body)
*
* @throws \Exception
*/
public function sendSms(string $number, string $body, $callback)
public function sendSms(string $number, string $body, string $callback, ?SmsAndroidSetting $smsAndroidSetting = null)
{
$httpClient = new Client();
if ($number[0] !== '+') {
Expand Down
Loading