eks release workflow #405
eks release workflow #405
Conversation
k8s/deployments/mpm-backend.yaml
Outdated
| metadata: | ||
| name: mpm-backend | ||
| spec: | ||
| progressDeadlineSeconds: 600 | ||
| replicas: 1 | ||
| revisionHistoryLimit: 10 | ||
| selector: | ||
| matchLabels: |
There was a problem hiding this comment.
As discussed, please do not change this file.
| if kubectl get deployment mpm-backend; then | ||
| kubectl rollout restart deployment/mpm-backend | ||
| else | ||
| echo "mpm-backend deployment does not exist, applying initial deployment..." | ||
| kubectl apply -f k8s/deployments/mpm-backend.yaml | ||
| fi |
There was a problem hiding this comment.
I don't think we need the if/else here. We always want to run both apply and rollout restart.
- The
applyis needed such that changes to the kubernetesyamlfiles are picked up. Which shouldn't happen that often. - The
rollout restartis needed such that the new image gets deployed.
| if kubectl get deployment mpm-frontend; then | ||
| kubectl rollout restart deployment/mpm-frontend | ||
| else | ||
| echo "mpm-frontend deployment does not exist, applying initial deployment..." | ||
| kubectl apply -f k8s/deployments/mpm-frontend.yaml | ||
| fi |
There was a problem hiding this comment.
Please also add a step that runs apply on services.
| name: Deploy to EKS | ||
|
|
||
| on: | ||
| release: | ||
| types: | ||
| - published | ||
| workflow_dispatch: |
There was a problem hiding this comment.
Having this as a separate workflow won't work. If a new release gets created this will run immediately. However, the deploy to DockerHub job takes around 1h usually. So, we Pull the Docker image before the new one is even available.
Could you instead, move the deploy job into the already existing release-publish-dockerhub.yaml, also rename it to deploy-demo. Then please add a need (see here) to depend on the release-publish
dmohns
deleted the
343-feature-request-reduce-the-need-for-container-interaction-in-demo-environment
branch
Brief summary of the change made
Are there any other side effects of this change that we should be aware of?
Describe how you tested your changes?
Pull Request checklist
Please confirm you have completed any of the necessary steps below.