Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider suggesting option -A to add and remove changed files #467

Closed
azeemba opened this issue Jan 2, 2023 · 2 comments · Fixed by #468
Closed

Consider suggesting option -A to add and remove changed files #467

azeemba opened this issue Jan 2, 2023 · 2 comments · Fixed by #468
Labels
status: pinned Should not be labeled as stale type: docs Documentation changes

Comments

@azeemba
Copy link
Contributor

azeemba commented Jan 2, 2023

The current documentation has a section on removing files. However, the documentation makes it sound like you have to know which files you want to remove in advance.

This doesn't have to be the case. The action already supports arbitrary arguments to git add. So -A/--no-ignore-removal can be used to ask git to commit any files that have been deleted in the local repository (just as it would have added any modified or new files).

I am happy to send a PR but I wanted to create an issue first to make sure my suggestion makes sense.
@azeemba azeemba added the type: question Further information is requested label Jan 2, 2023
@EndBug
Copy link
Owner

EndBug commented Jan 2, 2023

Seems like a good idea! Yeah, it would be great if you could submit a PR ❤️

azeemba added a commit to azeemba/add-and-commit that referenced this issue Jan 3, 2023
@azeemba
Add how to autodetect deleted files
c59a79e 
The existing instructions make sense for when a predetermined list of files need to be removed. This is likely not a common use case so I shortened that explanation. 
Also added the explanation on how to use `--no-ignore-removal` as the `add` setting to have deleted files autodetected.

Fixes EndBug#467
@azeemba azeemba mentioned this issue Jan 3, 2023
Merged
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the status: stale Inactive issues and PRs label Jan 23, 2023
@EndBug EndBug added status: pinned Should not be labeled as stale type: docs Documentation changes and removed type: question Further information is requested status: stale Inactive issues and PRs labels Jan 23, 2023
EndBug added a commit that referenced this issue Jan 23, 2023
@azeemba @EndBug
docs(README): add how to auto-detect deleted files (#468)
c7eeaf4 
* Add how to autodetect deleted files

The existing instructions make sense for when a predetermined list of files need to be removed. This is likely not a common use case so I shortened that explanation. 
Also added the explanation on how to use `--no-ignore-removal` as the `add` setting to have deleted files autodetected.

Fixes #467

* docs(README): update "Deleting files" paragraph

Co-authored-by: Federico <fgrandi30@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: pinned Should not be labeled as stale type: docs Documentation changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add how to autodetect deleted files azeemba/add-and-commit
2 participants
@azeemba @EndBug