Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pretty print the diff #107

Merged
merged 2 commits into from
Jan 19, 2022
Merged

Pretty print the diff #107

merged 2 commits into from
Jan 19, 2022

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Jan 18, 2022 •
edited
Loading

Provide a cleaner diff output making it easier to inspect the dry-run results.

Depends on DefinitelyTyped/DefinitelyTyped#58296

Added labels

type::bug [missing]
☀️ → type::bug
☀️ → #b60205
☀️ → describes erroneous operation

Updated labels

type::feature [changed]
feature → type::feature
#888888 → #fff2cc
user requested new functionality → request for a new feature or capability

Deleted labels

question [added]
question → ⚰️ 
#d4c5f9 → ⚰️ 
user asked question → ⚰️

@kenodegard kenodegard mentioned this pull request Jan 19, 2022
Merged
EndBug
EndBug approved these changes Jan 19, 2022
View reviewed changes
Copy link
Owner

@EndBug EndBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I have merged the other PR and now there's a merge conflict with the build file, you should be able to fix it by just re-building.
After that this is ready to be merged 👍🏻

@kenodegard
Copy link
Contributor Author

@EndBug rebased and everything looks good! thanks again for your quick responses!

@EndBug EndBug merged commit ed10455 into EndBug:main Jan 19, 2022
@EndBug
Copy link
Owner

EndBug commented Jan 19, 2022

Thank you for the contributions 😄

@kenodegard kenodegard deleted the pretty-print branch January 19, 2022 14:41
@EndBug EndBug added the type: feature New feature or feature request label Jan 19, 2022
@EndBug
Copy link
Owner

EndBug commented Jan 19, 2022

@all-contributors please add @kenodegard for their code contributions

@allcontributors allcontributors bot mentioned this pull request Jan 19, 2022
Merged
@allcontributors
Copy link
Contributor

@EndBug

I've put up a pull request to add @kenodegard! 🎉

@EndBug
Copy link
Owner

EndBug commented Jan 19, 2022

Everything has been published in v2.1.0 (also v2 and latest)
Thanks for the contributions ❤️

This was referenced Jan 20, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EndBug EndBug EndBug approved these changes

Assignees
No one assigned
Labels
type: feature New feature or feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenodegard @EndBug