Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac bundling #42

Merged
merged 31 commits into from
Jul 1, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
ba45226
Adding properties for bundle
pega3 Jun 28, 2020
0472af3
Updating dependencies
pega3 Jun 28, 2020
c13920f
Adding application icons
pega3 Jun 28, 2020
81ef18f
Adding bundling to github action
pega3 Jun 28, 2020
7c505b6
Trying to install bundle command
pega3 Jun 28, 2020
9060883
Merge branch 'master' into Mac_Bundling
pega3 Jun 29, 2020
0e7c879
Trying to improve build process
pega3 Jun 29, 2020
08fa85d
Update build.yaml
pega3 Jun 29, 2020
c21a666
Update build.yaml
pega3 Jun 29, 2020
b32696d
Display directory data
pega3 Jun 29, 2020
4119475
Triggering new build
pega3 Jun 29, 2020
9c3600e
Including stripping again
pega3 Jun 29, 2020
34babee
remove superflous stuff
pega3 Jun 29, 2020
60fc218
Strip not working
pega3 Jun 29, 2020
9573692
Now the execution flags are lost again
pega3 Jun 29, 2020
010b8cb
Trying to archive ourselves
pega3 Jun 29, 2020
522acba
Double-zip instead of tar
pega3 Jun 29, 2020
9a7cfd0
Fixing release
pega3 Jun 30, 2020
c750f56
Correcting release step
pega3 Jun 30, 2020
83d2935
Merge remote-tracking branch 'upstream/master'
pega3 Jun 30, 2020
49db3c3
Update Cargo.lock
pega3 Jun 30, 2020
86946ee
Merge branch 'master' into Mac_Bundling
pega3 Jun 30, 2020
2b38646
Added icon for Mac
pega3 Jun 30, 2020
c0c2aeb
Merge branch 'Mac_Bundling' of https://github.com/pega3/ESLauncher2 i…
pega3 Jun 30, 2020
db4bbb6
Incorporating MCO feedback
pega3 Jun 30, 2020
f13abb6
Adjusted size of images
pega3 Jun 30, 2020
1cf7cb0
Nicer formatting for readme.md
pega3 Jun 30, 2020
e641c92
Modified identifier
pega3 Jun 30, 2020
6d8b686
Incorporating changes to author and description
pega3 Jul 1, 2020
b93651a
And now I understand what the edition field is for...
pega3 Jul 1, 2020
883acb5
Merge master
MCOfficer Jul 1, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 21 additions & 8 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -70,19 +70,32 @@ jobs:
MACOSX_DEPLOYMENT_TARGET: 10.14
run: |
cargo build --verbose --release
mv target/release/eslauncher2 eslauncher2-x86_64-apple-darwin
- name: Strip binary
run: strip eslauncher2-x86_64-apple-darwin
- name: Archive binary
uses: actions/upload-artifact@v1
chmod 755 target/release/eslauncher2
ls -al target/release
MCOfficer marked this conversation as resolved.
Show resolved Hide resolved
- name: Package binary
run: |
cargo install cargo-bundle
cargo bundle --release
ls -al target/release/bundle/osx/ESLauncher2.app/Contents/MacOS
MCOfficer marked this conversation as resolved.
Show resolved Hide resolved
- name: Strip binary and mark as executable
run: |
strip target/release/bundle/osx/ESLauncher2.app/Contents/MacOS/eslauncher2
chmod 755 target/release/bundle/osx/ESLauncher2.app/Contents/MacOS/eslauncher2
ls -al target/release/bundle/osx/ESLauncher2.app/Contents/MacOS
MCOfficer marked this conversation as resolved.
Show resolved Hide resolved
- name: Package ourselves to prevent execution flag creep
run: |
cd target/release/bundle/osx
zip -r ESLauncher2.app.zip ESLauncher2.app
- name: Upload artifact
uses: actions/upload-artifact@v2
with:
name: eslauncher2-x86_64-apple-darwin
path: eslauncher2-x86_64-apple-darwin
name: ESLauncher2.app.zip
path: target/release/bundle/osx
- name: Release binary
if: startsWith(github.ref, 'refs/tags/')
uses: softprops/action-gh-release@v1
with:
files: |
eslauncher2-x86_64-apple-darwin
target/release/bundle/osx/ESLauncher2.app.zip
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@ target/
**/*.rs.bk
.idea
/*.iml
ESLauncher2.log
ESLauncher2.log
.DS_Store
Loading