Skip to content

Commit

Permalink
[incubator/kafka] Fix initContainer failure which did not error (helm…
Browse files Browse the repository at this point in the history
…#4400)

* [incubator/kafka] Fix initContainer failure which did not error

* [incubator/kafka] Set initContainer to fail when vars are undefined
  • Loading branch information
Joshua Dotson authored and rolanddb committed Apr 9, 2018
1 parent 05b9355 commit e94cfc1
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
2 changes: 1 addition & 1 deletion incubator/kafka/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v1
description: Apache Kafka is publish-subscribe messaging rethought as a distributed
commit log.
name: kafka
version: 0.4.3
version: 0.4.4
keywords:
- kafka
- zookeeper
Expand Down
6 changes: 4 additions & 2 deletions incubator/kafka/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,10 @@ spec:
- name: init-ext
image: "{{ .Values.external.init.image }}:{{ .Values.external.init.imageTag }}"
imagePullPolicy: "{{ .Values.external.init.imagePullPolicy }}"
args:
- -n ${POD_NAMESPACE} label pods ${POD_NAME} pod=${POD_NAME}
command:
- sh
- -euxc
- "kubectl label pods ${POD_NAME} --namespace ${POD_NAMESPACE} pod=${POD_NAME}"
env:
- name: POD_NAME
valueFrom:
Expand Down
4 changes: 2 additions & 2 deletions incubator/kafka/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ external:
firstListenerPort: 31090
domain: cluster.local
init:
image: "lachlanevenson/k8s-kubectl"
imageTag: "v1.9.3"
image: "lwolf/kubectl_deployer"
imageTag: "0.4"
imagePullPolicy: "IfNotPresent"

## Configuration Overrides. Specify any Kafka settings you would like set on the StatefulSet
Expand Down

0 comments on commit e94cfc1

Please sign in to comment.