Skip to content
This repository has been archived by the owner on Jul 17, 2020. It is now read-only.

Jd/output files #64

Merged
merged 6 commits into from
Jul 10, 2020
Merged

Jd/output files #64

merged 6 commits into from
Jul 10, 2020

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Jul 10, 2020

Handles the system mods when initializing.

@jd-lara jd-lara requested a review from rodrigomha July 10, 2020 20:57
@jd-lara jd-lara self-assigned this Jul 10, 2020
@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #64 into rh/init_models will decrease coverage by 1.69%.
The diff coverage is 90.90%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           rh/init_models      #64      +/-   ##
==================================================
- Coverage           87.86%   86.17%   -1.70%     
==================================================
  Files                  43       44       +1     
  Lines                1739     1808      +69     
==================================================
+ Hits                 1528     1558      +30     
- Misses                211      250      +39     
Impacted Files Coverage Δ
src/LITS.jl 100.00% <ø> (ø)
src/base/definitions.jl 70.00% <ø> (ø)
src/base/file_system.jl 80.00% <80.00%> (ø)
src/base/simulation.jl 84.61% <92.30%> (-0.11%) ⬇️
src/base/perturbations.jl 100.00% <100.00%> (ø)
...rc/initialization/generator_components/init_avr.jl 55.55% <0.00%> (-41.42%) ⬇️
src/utils/kwargs_check.jl 66.66% <0.00%> (+33.33%) ⬆️

time::Float64
Ybus::SparseMatrixCSC{Complex{Float64}, Int64}
end

get_affect(pert::ThreePhaseFault) =
get_affect(::PSY.System, pert::ThreePhaseFault) =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need system here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not for the fault, but for reference changes yeah

@jd-lara jd-lara merged commit d3e0687 into rh/init_models Jul 10, 2020
@jd-lara jd-lara deleted the jd/output_files branch July 10, 2020 22:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants