This repository has been archived by the owner on Jul 17, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rodrigomha this will also require the serialization of DynamicLines. |
Yes. We need that to use the |
jd-lara
reviewed
Jul 16, 2020
jd-lara
reviewed
Jul 16, 2020
jd-lara
reviewed
Jul 16, 2020
jd-lara
suggested changes
Jul 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several things in the result that retrieve code that is not necessary. Please see the comments, we already have a sorted dict with the lookup in the simulation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR updates Test 10 and 11 to properly assess the effects of Dynamic Lines.
It also adds an update model for Source, that now uses an internal voltage and angle to match the solution of the power flow (via a new initialization function). Finally, new functions to print initial conditions are provided. The new printer provides bus voltages, states of dynamic devices and current for dynamic lines.
To do: