Skip to content
This repository has been archived by the owner on Jul 17, 2020. It is now read-only.

Update Docs #69

Merged
merged 2 commits into from
Jul 16, 2020
Merged

Update Docs #69

merged 2 commits into from
Jul 16, 2020

Conversation

rodrigomha
Copy link
Member

This finishes the update of the examples and docs for LITS 0.4.0

@rodrigomha rodrigomha requested a review from jd-lara July 16, 2020 21:37
@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #69 into master will increase coverage by 5.68%.
The diff coverage is 76.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   87.71%   93.40%   +5.68%     
==========================================
  Files          43       45       +2     
  Lines        1718     1970     +252     
==========================================
+ Hits         1507     1840     +333     
+ Misses        211      130      -81     
Impacted Files Coverage Δ
src/LITS.jl 100.00% <ø> (ø)
src/base/definitions.jl 25.00% <ø> (-45.00%) ⬇️
...rc/initialization/generator_components/init_pss.jl 100.00% <ø> (ø)
...itialization/inverter_components/init_converter.jl 100.00% <ø> (+100.00%) ⬆️
src/models/dynline_model.jl 100.00% <ø> (+100.00%) ⬆️
src/models/generator_models/pss_models.jl 100.00% <ø> (+84.61%) ⬆️
src/utils/ybus_utils.jl 24.48% <24.48%> (ø)
src/base/simulation_initialization.jl 55.05% <40.35%> (-27.81%) ⬇️
src/utils/plot_utils.jl 76.66% <73.33%> (-23.34%) ⬇️
src/base/file_system.jl 80.00% <80.00%> (ø)
... and 25 more

@@ -73,7 +73,7 @@ Based on the description provided in PTI files, this is a two-bus system, on whi
```julia
#To create the system you need to pass the location of the RAW file
file_dir = "OMIB.raw"
omib_sys = System(omib_file_dir)
omib_sys = System(PowerModelsData(omib_file_dir))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let load directly

Suggested change
omib_sys = System(PowerModelsData(omib_file_dir))
omib_sys = System(omib_file_dir)

Copy link
Member

@jd-lara jd-lara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small change request

@jd-lara jd-lara merged commit bfa565e into master Jul 16, 2020
@jd-lara jd-lara deleted the rh/update_docs_dyn_line branch July 16, 2020 22:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants