New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve pr comments #2

Merged

ee-naveen merged 3 commits into master from naveen/resolve_pr_comments_1

Aug 15, 2023

ee-naveen commented Aug 14, 2023 •

edited

Loading

resolve pr comments. aloneguid#382

should stay private : removed public from DeltaBinaryPackedEncoder class
In case of long, will this lose precision? : added WriteZigZagVarLong function and refactored (removed other functions)
FYI renting small buffers is expensive, probably more than creating them directly.: creating the buffer directly
should be moved to OtherExtensions.cs : Added extension method for zigzag

ee-naveen added 3 commits

August 14, 2023 22:42


          resolve pr comments

af73e2d


          Added ZigZagEncoded function to other extention class

7dcf2d1


          fixed typo

ff44a24

ee-naveen requested a review from eeabhishekmore

August 14, 2023 17:58

eeabhishekmore approved these changes

View reviewed changes

ee-naveen merged commit 4dffe87 into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet