Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling C-ECHO with storescp cli command #337

Closed
PierreBou91 opened this issue Apr 4, 2023 · 1 comment
Closed

Handling C-ECHO with storescp cli command #337

PierreBou91 opened this issue Apr 4, 2023 · 1 comment
Labels
A-tool Area: tooling C-storescp Crate: dicom-storescp

Comments

@PierreBou91
Copy link
Contributor

Hello,

Thanks for this great project.

In an attempt to learn Rust and improve my understanding of the dicom standard, I am working on a very basic EAI (enterprise application integration). In doing so, I reused most of the storescp code from dicom-rs and I added the possibility to handle the C-ECHO request (It's enough to check the command value in the main loop and format a C-ECHO response).

Is it relevant to adapt my code to the storescp in this project and make a pull request or was this omission intentional ?

Have a nice day,

Pierre

@Enet4
Copy link
Owner

Enet4 commented Apr 4, 2023

Hello! Thank you for your interest in DICOM-rs. I agree that there is value in storescp implementing the verification SOP class, so I would be happy to review your pull request!

@Enet4 Enet4 added A-tool Area: tooling C-storescp Crate: dicom-storescp labels Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tool Area: tooling C-storescp Crate: dicom-storescp
Projects
None yet
Development

No branches or pull requests

2 participants