-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle C-ECHO request in storeSCP CLI tool #338
Handle C-ECHO request in storeSCP CLI tool #338
Conversation
This commit adds support for handling C-ECHO requests in the storeSCP CLI tool. With this update, the storeSCP tool can now process incoming C-ECHO requests and send appropriate responses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for looking into this feature, @PierreBou91!
Could you please rustfmt this source file? The changes added do not seem to follow the rest of the formatting.
Minor suggestion inline.
I forgot to fmt, apologies for that. Thanks for the suggestion regarding the switch to |
Co-authored-by: Eduardo Pinho <enet4mikeenet@gmail.com>
I also got rid of the useless array in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tried it out in practice and it appears to be responding well to C-ECHO requests. Found no regressions of the standard storage service either, so this is good to enter! Thank you very much!
This commit adds support for handling C-ECHO requests in the storeSCP CLI tool. With this update, the storeSCP tool can now process incoming C-ECHO requests and send appropriate responses.
Related to issue #337
Before screenshot:

After screenshots:

It appears that the main functionality of the storescp is maintained:

All test passed after
cargo test
The changes in
transfer.rs
were relevant to:Please tell me if any additions / modification / deletion are needed.