-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add attribute operations API #326
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43abba0
to
de7991f
Compare
de7991f
to
8d7b565
Compare
- retrieve both parts of the data element, consuming it
- extend_i16 - extend_u16 - extend_f32 - extend_f64 - also update documentation of extend_* methods to emphasize the possible loss of precision
- `ops`, with `AttributeOpt` and `AttributeAction`
- add ops module for `ApplyError` and `ApplyError` - impl ApplyOp for FileMetaTable - currently only supports modifying known textual attributes - impl ApplyOp for InMemDicomObject
- use if let instead of .map returning ()
- add ops module - remove unnecessary links - remove mention of nonexisting error module
8d7b565
to
7d35344
Compare
Enet4
commented
Mar 16, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings a new common API for applying specific changes to attributes in a DICOM object or object-like type. This has been implemented for all DICOM object types, namely
InMemDicomObject
,FileDicomObject
andFileMetaTable
.Example of use:
Summary
DataElement::into_parts
PrimitiveValue::extend_*
methods for other data typesops
, withAttributeOp
,AttributeAction
, andApplyOp
ApplyOp
for current object typesget
andtake
forInMemDicomObject
, return an option instead of a result.