Change ReadPreamble::Auto to automatic preamble detection #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- try to find the preamble by filling the reader buffer and looking for the DICM magic string - update documentation and tests accordingly
Enet4
force-pushed
the
imp/object/read-preamble-auto
branch
from
82333f7 to
391e270
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the default behavior of automatically detecting whether the 128-byte preamble is present, making DICOM object reading functions easier to use.
Summary
ReadPreambleisAuto, try to find the preamble by filling the reader buffer and looking for theDICMmagic string.