Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using dicom_value! without smallvec import #366

Merged
merged 6 commits into from
Jun 14, 2023

Conversation

Enet4
Copy link
Owner

@Enet4 Enet4 commented Jun 14, 2023

This fixes an item naming error which was preventing users of dicom_core from using the dicom_value! macro unless they also imported smallvec explicitly.

The crates echoscu, findscu, storescu, and storescp were also updated, since they were importing smallvec unnecessarily, and sometimes adding smallvec as a dependency.

@Enet4 Enet4 added bug This is a bug C-core Crate: dicom-core labels Jun 14, 2023
@Enet4 Enet4 merged commit 07dc7a9 into master Jun 14, 2023
@Enet4 Enet4 deleted the bug/core/dicom_value_smallvec branch June 14, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is a bug C-core Crate: dicom-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant