Adding the PDU types.

[pauldotknopf]

No description provided.

[pauldotknopf]

This pull request is now ready. I've added an scpproxy tool for debug/diagnosing issues between SCU/SCP.

USAGE:
    scpproxy [OPTIONS] <destination-host> <destination-port>

FLAGS:
    -h, --help       Prints help information
    -V, --version    Prints version information

OPTIONS:
    -l, --listen-port <listen-port>    The port that we will listen for SCU connections on [default: 3333]

ARGS:
    <destination-host>    The destination host name (SCP)
    <destination-port>    The destination host port (SCP)

Here is an example output of an echo request.

listening on: 0.0.0.0:3333
forwarding to: 127.0.0.1:2222
scu ----> scp: AssociationRQ { protocol_version: 1, calling_ae_title: "ECHOSCU", called_ae_title: "ANY-SCP", application_context_name: "1.2.840.10008.3.1.1.1", presentation_contexts: [PresentationContextProposed { id: 1, abstract_syntax: "1.2.840.10008.1.1", transfer_syntaxes: ["1.2.840.10008.1.2"] }], user_variables: [MaxLength(16384), ImplementationClassUID("1.2.276.0.7230010.3.0.3.6.4"), ImplementationVersionName("OFFIS_DCMTK_364")] }
scu <---- scp: AssociationAC { protocol_version: 1, application_context_name: "1.2.840.10008.3.1.1.1", presentation_contexts: [PresentationContextResult { id: 1, reason: Acceptance, transfer_syntax: "1.2.840.10008.1.2" }], user_variables: [MaxLength(16384), ImplementationClassUID("1.2.276.0.7230010.3.0.3.6.4"), ImplementationVersionName("OFFIS_DCMTK_364")] }
scu ----> scp: PData { data: [PDataValue { presentation_context_id: 1, value_type: Command, is_last: true, data: [0, 0, 0, 0, 4, 0, 0, 0, 56, 0, 0, 0, 0, 0, 2, 0, 18, 0, 0, 0, 49, 46, 50, 46, 56, 52, 48, 46, 49, 48, 48, 48, 56, 46, 49, 46, 49, 0, 0, 0, 0, 1, 2, 0, 0, 0, 48, 0, 0, 0, 16, 1, 2, 0, 0, 0, 1, 0, 0, 0, 0, 8, 2, 0, 0, 0, 1, 1] }] }
scu <---- scp: PData { data: [PDataValue { presentation_context_id: 1, value_type: Command, is_last: true, data: [0, 0, 0, 0, 4, 0, 0, 0, 66, 0, 0, 0, 0, 0, 2, 0, 18, 0, 0, 0, 49, 46, 50, 46, 56, 52, 48, 46, 49, 48, 48, 48, 56, 46, 49, 46, 49, 0, 0, 0, 0, 1, 2, 0, 0, 0, 48, 128, 0, 0, 32, 1, 2, 0, 0, 0, 1, 0, 0, 0, 0, 8, 2, 0, 0, 0, 1, 1, 0, 0, 0, 9, 2, 0, 0, 0, 0, 0] }] }
scu ----> scp: ReleaseRQ
scu <---- scp: ReleaseRP
shutdown initiated from: SCU

[pauldotknopf]

I will be submitting another pull request that will implement an echoscp and echoscu command. They won't be super useful, but they will ensure the correctness of the state machine that will be built with them.

[Enet4]

Thank you very much for the efforts deposited on the project so far!

This is the first review iteration. A bunch of suggestions and nitpicks below. I hope that they won't overwhelm you. Please take your time and leave a comment if you're having trouble dealing with any of them.

On a broader perspective, wouldn't it make sense to delegate some of these mechanisms to the encoding crate, which is already dedicated to the reading/writing of DICOM elements and loading text with the intended character set?

[pauldotknopf]

I fully expected some changes, so no worries.

I made the changes you requested. I'm ready for another review.

[pauldotknopf]

Also, give me a heads up before you merge, and I'll squash these commits.

[Enet4]

Here's the second wave.

[pauldotknopf]

Ready for you again.

[Enet4]

Here's another wave of nitpicks, but it should be ready to merge very soon.

[pauldotknopf]

Ready for you again.

[Enet4]

This should be ready to become part of the crate roster. Thank you very much!