Fix the characteristic that the trim() and trim_end() functions do not remove the \0 character. #620
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #618
Hello @Enet4 ,
I have standardized the codebase by uniformly substituting the
trim()
andtrim_end()
functions with thetrim_end_matches([' ', '\u{0}'])
function, which was replicated from theto_str()
function within theprimitive.rs
file.I am rather uncertain as to the rationale behind the concurrent existence of the
trim()
andtrim_end()
andtrim_end_matches([' ', '\u{0}'])
functions in the previous implementation. Was this a deliberate design choice?Moreover, I am pondering whether it might be more apt to utilize the
trim_matches(|c: char| c == '\0' || c.is_whitespace())
function instead. However, I remain indecisive on this matter.