Preserve string values on data set reading #65
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #9. It introduces configurable value reading strategies (
ValueReadStrategy
) at data set reading level and makesPreserve
the default one. Quoting from the documentation:With #56 already present, working with
PrimitiveValue
should be easy enough, performing the conversions to binary numbers and date/time/datetime only when necessary via the methods added there.Note also that this does not exclude the eventual attribute abstraction, which will exist at the object level and even work with values which are not necessarily in memory. Everything should hopefully fit like puzzle pieces once this one is done.