Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimension 1 bug #64

Merged
merged 2 commits into from
Feb 24, 2020
Merged

Dimension 1 bug #64

merged 2 commits into from
Feb 24, 2020

Conversation

nilgoyette
Copy link
Collaborator

I'm not entirely happy with this fix because I don't understand why it works :| It make sense that writing the data bytes of a (1, 5, 5, 5) image is the same as writing them for a (5, 5, 5) image. The first dimension adds nothing interesting that should concern the write_data function. However, it looks like iterating on a dim=1 change the ordering. When I skip the dim=1, it works as intended.

Anyway, I'm still pushing this branch because I have other things to do, but if you have a better understanding of the problem than me, I'm interested!

Fix #63

@nilgoyette nilgoyette requested a review from Enet4 February 24, 2020 14:43
@nilgoyette
Copy link
Collaborator Author

I requested you as reviewer because I don't even know if you saw this PR.

Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. I had looked into this issue, and indeed reproduced it on my machine, but in my attempts to better understand what was going on, it got postponed almost indefinitely.

Considering that the crate is better off with this tweak than without any solution, I agree to merge. We can keep on the look out for similar issues, chances of something else being at play might not be entirely nil.

Thank you very much, and sorry for the time inconvenience.

@Enet4 Enet4 merged commit ccee88a into Enet4:master Feb 24, 2020
@nilgoyette nilgoyette deleted the dim_1_bug branch June 4, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Writing 4D images with a single volume
2 participants