Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove traits for into_ndarray #83

Merged
merged 1 commit into from
Jan 16, 2021
Merged

Remove traits for into_ndarray #83

merged 1 commit into from
Jan 16, 2021

Conversation

nilgoyette
Copy link
Collaborator

It seems that T: Mul<Output = T>, and T: Add<Output = T>, are no longer used for the into_ndarray functions.

Enet4
Enet4 approved these changes Jan 16, 2021
View reviewed changes
Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable indeed. DataElement already implies (albeit not formally) that it can be converted to values which support these arithmetical operations anyway.

@Enet4 Enet4 merged commit 19668e6 into master Jan 16, 2021
@Enet4 Enet4 deleted the less_traits branch January 16, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enet4 Enet4 Enet4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilgoyette @Enet4