Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] eng_customer_fiscal_comments: Migration to 16.0 #36

Conversation

CristianoMafraJunior
Copy link
Collaborator

Migração padrão

@antoniospneto antoniospneto mentioned this pull request Feb 3, 2025
20 tasks
@CristianoMafraJunior CristianoMafraJunior force-pushed the 16.0-mig-eng_customer_fiscal_comments branch from 5699811 to f899623 Compare February 3, 2025 19:19
@CristianoMafraJunior CristianoMafraJunior marked this pull request as draft February 3, 2025 19:29
@CristianoMafraJunior CristianoMafraJunior changed the title [16.0][MIG] eng customer fiscal comments: Migration to 16.0 [16.0][MIG] eng_customer_fiscal_comments: Migration to 16.0 Feb 3, 2025
@CristianoMafraJunior CristianoMafraJunior force-pushed the 16.0-mig-eng_customer_fiscal_comments branch 2 times, most recently from e0f3e32 to 7ff84c1 Compare February 3, 2025 19:53
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (16.0@5ec2706). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...r_fiscal_comments/models/document_mixin_methods.py 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             16.0      #36   +/-   ##
=======================================
  Coverage        ?   92.30%           
=======================================
  Files           ?        6           
  Lines           ?       26           
  Branches        ?        2           
=======================================
  Hits            ?       24           
  Misses          ?        1           
  Partials        ?        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CristianoMafraJunior
Copy link
Collaborator Author

@antoniospneto removido a dependência do l10n_br_nfe pois não é necessário e estava dando erro no teste.

@CristianoMafraJunior CristianoMafraJunior marked this pull request as ready for review February 3, 2025 19:57
@antoniospneto
Copy link
Contributor

@CristianoMafraJunior consegue adicionar um caso de testes, cadastrar um comentário fiscal no cliente e depois gerar um documento para esse cliente e checar se o comentário foi carregado no documento?

@CristianoMafraJunior CristianoMafraJunior force-pushed the 16.0-mig-eng_customer_fiscal_comments branch from 3122474 to c227cd2 Compare February 3, 2025 22:45
@CristianoMafraJunior CristianoMafraJunior force-pushed the 16.0-mig-eng_customer_fiscal_comments branch from c227cd2 to 0e2d768 Compare February 3, 2025 22:49
@CristianoMafraJunior
Copy link
Collaborator Author

@CristianoMafraJunior consegue adicionar um caso de testes, cadastrar um comentário fiscal no cliente e depois gerar um documento para esse cliente e checar se o comentário foi carregado no documento?

Adicionei o caso de Teste bem basico e correções no arquivo DESCRIPTION.md

@antoniospneto
Copy link
Contributor

Valeu! @CristianoMafraJunior

@antoniospneto antoniospneto merged commit b865b4d into Engenere:16.0 Feb 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants