Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

//structure generates empty chests #2669

Closed
5 tasks done
wizjany opened this issue Dec 6, 2024 · 0 comments · Fixed by #2674
Closed
5 tasks done

//structure generates empty chests #2669

wizjany opened this issue Dec 6, 2024 · 0 comments · Fixed by #2674
Labels
status:accepted Will be fixed / added to WorldEdit, eventually type:bug Incorrect behavior, not working as intended

Comments

@wizjany
Copy link
Collaborator

wizjany commented Dec 6, 2024

WorldEdit Version

7.3.10-SNAPSHOT, 7.3.8

Platform Version

Paper 1.21.4, Fabric 1.21

Confirmations

  • I am using the most recent Minecraft release.
  • I am using a version of WorldEdit compatible with my Minecraft version.
  • I am using the latest or recommended version of my platform software.
  • I am NOT using a hybrid server, e.g. a server that combines Bukkit and Forge. Examples include Arclight, Mohist, and Cardboard.
  • I am NOT using a fork of WorldEdit, such as FastAsyncWorldEdit (FAWE) or AsyncWorldEdit (AWE)

Bug Description

Chests (and possible other blocks) generated via the //structure command don't have loot tables, and thus are empty.

Expected Behavior

Chests generate with loot.

Reproduction Steps

  1. //structure desert_pyramid (or anything else that spawns with a chest with loot)
  2. Open chests, see that they are all empty. Can be verified by checking NBT before opening chest (should have loot table tag, see below).

Anything Else?

Tested on 1.21.4 adapters, which have a small change to the generate signature, but reproduced in 1.21.

Image

This may (probably does) affect any other blocks with NBT in structures.

This was previously fixed (for paper only) in d1221cf, but since the re-enabling of the buffering extents, the BE is never created as the block doesn't get set to the world til the ES is closed, so getBlockEntity returns null.

@wizjany wizjany added status:pending Pending acceptance or closure. type:bug Incorrect behavior, not working as intended status:accepted Will be fixed / added to WorldEdit, eventually and removed status:pending Pending acceptance or closure. labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:accepted Will be fixed / added to WorldEdit, eventually type:bug Incorrect behavior, not working as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant