Make it work with concourse v7 and golang 1.16 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 10, 2021 13:53
this is needed for golang 1.16 as the build fails with such error message:
github.com/EngineerBetter/stopover imports
github.com/concourse/concourse/atc: cannot find module providing package github.com/concourse/concourse/atc
github.com/EngineerBetter/stopover imports
github.com/concourse/concourse/go-concourse/concourse: cannot find module providing package github.com/concourse/concourse/go-concourse/concourse
pipelines have their own type now with Name being a specific field. Also fixed some issues around new version of Hoverfly
and compare strings as *gbytes.Buffer was somehow different even if the string is same and we couldn't find why
|
I've tested this on Concourse 5.8.1 and 6.7.4 and it appears to work. @BooleanCat confirmed the tests passed earlier. LGTM 🚢 |
|
Thanks for the work on this, appreciated @combor! |
|
I've shipped v2.0.1 with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
stopover is failing to compile on golang 1.16 and throwing such error:
we had to move vendoring method to use go mod and re-vendor all dependencies.
This made us also to fix some tests to use newer structures form go-concourse client and fix tests.
We also had to record new responses for howerfly as it was upgraded to v5 schema and the old recording was not compatible as it was using v3.
How to test