Edit Testing Workflow #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I'm a bit busy recently so can't review until things clear up, but thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey everyone - just came across Bagels and I've enjoyed using it so far!
Wanted to help the cause by contributing to the testing workflow:
test.ymlwhich callspytestusinguv.bagels.config.CONFIGvalue fromNoneto an instance ofbagels.config.Config(). This resolved failed test cases that raisedAttributeErrors for accessing values that did not exist.To my understanding, changing the default
CONFIGvalue only impacts testing. When running the app, this value is overwritten by an instance ofbagels.config.Config()whenbagels.config.load_config()is called anyway.Also assuming that the failed test cases would pass if the secrets accessible on my machine. Let me know if I'm wrong.
Happy to edit anything proposed.
Thanks!