Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-genned NBT to thermal cells, fixes RS autocrafting with them. #4086

Merged

Conversation

Rodg88
Copy link
Contributor

@Rodg88 Rodg88 commented Jan 19, 2022

Adding the NBT from a newly crafted thermal cell to the default output for thermal cells stops RS autocrafting getting really confused. Just re-encode your patterns for the energy and fluid cells after updating.

This is in the kube expert branch as I don't think normal mode has anything that uses crafted thermal cells as inputs? Could go in kube base branch instead though without hurting anything, if the if (global.isExpertMode == false) conditional was removed.

Adding the NBT from a newly crafted thermal cell to the default output for thermal cells stops RS autocrafting getting really confused.
Copy link
Collaborator

@NielsPilgaard NielsPilgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we may need to change the values if we ever reconfigure how much they can hold though.

@NielsPilgaard NielsPilgaard merged commit b6406c2 into EnigmaticaModpacks:develop Jan 19, 2022
@Rodg88 Rodg88 deleted the ThermalCellFixFinalFinal branch January 19, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants