Bug Fix- list of input types #107
Conversation
|
|
||
| private graphql.schema.GraphQLType getOrPutInRegistry(graphql.schema.GraphQLType graphQLType) { | ||
| graphql.schema.GraphQLType typeFromRegistry = typeRegistry.get(graphQLType.getName()); | ||
| if (typeFromRegistry!=null) |
There was a problem hiding this comment.
please use braces in the if and else
| Stack<graphql.schema.GraphQLType> typesStack= new Stack<>(); | ||
| typesStack = getWrappedTypesStack(graphQLType, typesStack); | ||
| graphql.schema.GraphQLType wrappedType = typesStack.pop(); | ||
| if (wrappedType instanceof GraphQLObjectType){ |
There was a problem hiding this comment.
What if I have an interface? will this still work? (I don't remember if an interface is also an objectType)
There was a problem hiding this comment.
It won't, but Im not sure if we should handle it the same way
|
He doesn't solve issue #78 entirely. This PR allows List of List of List (...) of Input Type (it handles it recursively), while his PR does not. |
|
Actually List of List of List of Input types work in #94 , I've just added a unit test. It also allows you to use constructor with typed fields instead of simple map, which makes possible to use more complex type ( in the unit test, an input containing a list of other objects ) |
| collect(Collectors.toList())); | ||
| } | ||
|
|
||
| private GraphQLInputType handleGraphQLList(graphql.schema.GraphQLType type) { |
There was a problem hiding this comment.
I think it is better that the function get a GraphQLList as an input
|
Do you have tests that check list of inputs? |
| } | ||
| } | ||
|
|
||
| private graphql.schema.GraphQLType getOrPutInRegistry(graphql.schema.GraphQLType graphQLType) { |
| GraphQLInputObjectType inputObject = getInputObject((GraphQLObjectType) wrappedType, "input"); | ||
| inputObject = (GraphQLInputObjectType) getOrPutInRegistry(inputObject); | ||
| inputType = inputObject; | ||
| while (!typesStack.isEmpty()) { |
There was a problem hiding this comment.
extract to different method
fixes the bug of unsupported list of input types as an argument
fixing issue #78
fixing issue #90