DataFetcherConstructor args constructor as the annotation + tests #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guy120494
reviewed
May 10, 2018
| Constructor<? extends DataFetcher> constructor; | ||
| if (x.getParameterTypes().length == 1 && x.getParameterTypes()[0] == String[].class) { | ||
| constructor = annotatedDataFetcher.value().getDeclaredConstructor(String[].class); | ||
| return constructNewInstance(constructor, new Object[]{args}); |
There was a problem hiding this comment.
new Object[]{args} -> (Object[]) args
There was a problem hiding this comment.
it's in purpose that way
new Object[]{args} create a single variable of object[],
and (Object[]) is a casting that casts to a object array, and the String[] ctor expecting only one argument...
|
Please udpate the readme with all the possible options of how the constructor of datafetche can look like |
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@GraphQLDataFetcher have args (String[]) fields, and the class thats implements DataFetcher should expect to get those args with String[] constructor...
of course that it's have Backwards compatibility
wrote some tests for the DataFetcherConstructor class