Fix method data fetcher #175
Conversation
…not from the environment field
| Field field = source.getClass().getDeclaredField(fieldName); | ||
| field.setAccessible(true); | ||
| return field.get(source); | ||
| private Object getGraphQLFieldValue(Object source, String fieldName) throws IllegalAccessException, NoSuchFieldException, InvocationTargetException { |
There was a problem hiding this comment.
Separate to few methods, one that deals with fields and one that deals with methods
| return field.get(source); | ||
| private Object getGraphQLFieldValue(Object source, String fieldName) throws IllegalAccessException, NoSuchFieldException, InvocationTargetException { | ||
| Method method = getMethod(source.getClass(), fieldName, ""); | ||
| Method getMethod = getMethod(source.getClass(), fieldName, "get"); |
There was a problem hiding this comment.
call this method only if necessary (reflection takes a lot of time)
| private Object getGraphQLFieldValue(Object source, String fieldName) throws IllegalAccessException, NoSuchFieldException, InvocationTargetException { | ||
| Method method = getMethod(source.getClass(), fieldName, ""); | ||
| Method getMethod = getMethod(source.getClass(), fieldName, "get"); | ||
| Method isMethod = getMethod(source.getClass(), fieldName, "is"); |
There was a problem hiding this comment.
call this method only if necessary (reflection takes a lot of time)
| package graphql.annotations.processor.util; | ||
|
|
||
| public class PrefixesUtil { | ||
| public static String createPrefix(String prefix, String propertyName) { |
There was a problem hiding this comment.
The name of the function doesn't explain what the function does
| Field field = null; | ||
| while (clazz != null && field == null) { | ||
| try { | ||
| field = clazz.getDeclaredField(name); |
There was a problem hiding this comment.
should it be "getDeclaredField" or "getField"?
There was a problem hiding this comment.
getField returns only public fields (but for entire hirearchy), but we need private ones as well. So this method runs over the entire hirearchy and searches for private methods with this name.
2 participants
fix #174