Skip to content

Fixing GraphQLDeprecate not showing in graphiql #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 14, 2019
Merged

Fixing GraphQLDeprecate not showing in graphiql #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
978ed47
Merge pull request #216 from Enigmatis/development
yarinvak Jul 9, 2019
06fc05b
Merge branches 'development' and 'master' of https://github.com/graph…
yarinvak Aug 14, 2019
bbb8b73
if empty string is sent as a description in @GraphQLDeprecate - set i…
yarinvak Aug 14, 2019
014cfad
if empty string is sent as a description in @GraphQLDeprecate - set i…
yarinvak Aug 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/graphql/annotations/processor/retrievers/fieldBuilders/DeprecateBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public DeprecateBuilder(AccessibleObject object) {
public String build() {
GraphQLDeprecate deprecate = object.getAnnotation(GraphQLDeprecate.class);
if (deprecate != null) {
return deprecate.value();
return deprecate.value().isEmpty() ? DEFAULT_DEPRECATION_DESCRIPTION : deprecate.value();
}
if (object.getAnnotation(Deprecated.class) != null) {
return DEFAULT_DEPRECATION_DESCRIPTION;
Expand Down
2 changes: 1 addition & 1 deletion ...est/java/graphql/annotations/processor/retrievers/fieldBuilders/DeprecateBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public void build_graphQLDeprecateAnnotationExistsWithNoValue_returnEmptyString(
String deprecate = deprecateBuilder.build();

// assert
assertEquals(deprecate, "");
assertEquals(deprecate, "Deprecated");
}

@Test
Expand Down