Use actual graphql name on extending type #301
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a type is extended via a
GraphQLTypeExtension
annotation, the simple class name is used instead of checking whether a GraphQLName annotation is available; if the GraphQL name differs from the class name, the field cannot be fetched.Example:
All the fields from the
GqlCurrentUser
class will be added withCurrentUser
as the parent name. While handling the extension, the fields will be registered withGqlCurrentUser
as the parent name, which does not match the actual parent.graphql-java-annotations/src/main/java/graphql/annotations/processor/typeBuilders/OutputObjectBuilder.java
Line 82 in 74dd8c8
vs
graphql-java-annotations/src/main/java/graphql/annotations/processor/retrievers/GraphQLExtensionsHandler.java
Line 62 in 74dd8c8