-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transform get_pull to return full list of open PRs matching commit #244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, this really looks like a great "first good issue". Only minor comments.
Unit Test Results (reference) 54 files ±0 54 suites ±0 2m 38s ⏱️ +13s Results for commit 4bcd0b4. ± Comparison against base commit 71bf14b. This pull request removes 11 and adds 11 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
I have simplified the "hiding comments" logging message and rework the logging in general, plus adjusted the tests. |
Unit Test Results (setup-python) 54 files ±0 54 suites ±0 2m 34s ⏱️ +9s Results for commit 4bcd0b4. ± Comparison against base commit 71bf14b. This pull request removes 11 and adds 11 tests. Note that renamed tests count towards both.
|
Unit Test Results (Linux) 54 files ±0 54 suites ±0 2m 34s ⏱️ +9s Results for commit 4bcd0b4. ± Comparison against base commit 71bf14b. This pull request removes 11 and adds 11 tests. Note that renamed tests count towards both.
|
Unit Test Results (macOS) 54 files ±0 54 suites ±0 2m 34s ⏱️ +9s Results for commit 4bcd0b4. ± Comparison against base commit 71bf14b. This pull request removes 11 and adds 11 tests. Note that renamed tests count towards both.
|
Unit Test Results (Windows) 54 files ±0 54 suites ±0 2m 34s ⏱️ +9s Results for commit 4bcd0b4. ± Comparison against base commit 71bf14b. This pull request removes 11 and adds 11 tests. Note that renamed tests count towards both.
|
Unit Test Results (Test Files) 25 files ±0 4 errors 22 suites ±0 39m 12s ⏱️ ±0s For more details on these parsing errors, failures and errors, see this check. Results for commit 4bcd0b4. ± Comparison against base commit 71bf14b. |
Unit Test Results (Dockerfile) 54 files ±0 54 suites ±0 2m 34s ⏱️ +9s Results for commit 4bcd0b4. ± Comparison against base commit 71bf14b. This pull request removes 11 and adds 11 tests. Note that renamed tests count towards both.
|
Unit Test Results (Docker Image) 54 files ±0 54 suites ±0 2m 34s ⏱️ +9s Results for commit 4bcd0b4. ± Comparison against base commit 71bf14b. This pull request removes 11 and adds 11 tests. Note that renamed tests count towards both.
|
Looks like this works pretty well: https://github.com/EnricoMi/publish-unit-test-result-action/runs/5807698802?check_suite_focus=true#step:7:11 |
Looks like everything is fine, I have no write access so I assume it's up to you to merge the PR, can you please notify me when the change gets released? |
Thanks for the contribution! |
Hi @EnricoMi , do you need to create a new release for this change to take effect? This morning the changes didn't take effect on our CI jobs. |
I'll release this in a few days. |
This has been released. |
resolves #242