-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish results as job summary #266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. A few minor comments but nothing controversial.
Can we move the test path related changes into a separate PR that we merge first? Just to keep that separated from the job summary code.
Well, I think pretty much all comments have been covered 😌 |
PR #267 is merged, please rebase and I will review again tomorrow. |
This comment has been minimized.
This comment has been minimized.
Unit Test Results (Test Files) 26 files ±0 4 errors 23 suites ±0 39m 21s ⏱️ ±0s For more details on these parsing errors, failures and errors, see this check. Results for commit e5bc065. ± Comparison against base commit b406f72. ♻️ This comment has been updated with latest results. |
Look at this (scroll down to the job summaries): https://github.com/EnricoMi/publish-unit-test-result-action/actions/runs/2306018943 |
What about this markdown for the job summary (reference comment and check)? Currently: 4 parse errors, 6 errors, 25 fail, 20 skipped, 228 pass in 39m 21s 26 files 4 errors 23 suites 39m 21s ⏱️ Results for commit 9eac4d8. With title and one-line summary: Unit Test Results (Test Files)4 parse errors, 6 errors, 25 fail, 20 skipped, 228 pass in 39m 21s 26 files 4 errors 23 suites 39m 21s ⏱️ Results for commit 9eac4d8. Like the comment, not the check: Unit Test Results (Test Files) 26 files 4 errors 23 suites 39m 21s ⏱️ Results for commit 9eac4d8. |
Which one do you prefer? I assume it's about not passing the title to get to the last one (my personal favorite) |
Yes, I prefer that one too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for the contribution! |
As those environment files are a GitHub Actions feature, I have added them to I am going to migrate |
This has been released, enjoy! |
Fixes #264
I took the liberty of enhancing the tests to use absolute paths for files, it's easier to run tests in my IDE.