Add formatted numbers to JSON #298
Conversation
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
python/publish/publisher.py
Outdated
| @@ -309,7 +350,7 @@ def publish_json(self, data: PublishData): | |||
There was a problem hiding this comment.
Incompatible parameter type: Expected Union[os.PathLike[bytes], os.PathLike[str], bytes, str] for 1st positional only parameter to call os.unlink but got Optional[str].
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| @@ -53,6 +53,7 @@ def create_settings(comment_mode=comment_mode_create, | |||
| event: Optional[dict] = {'before': 'before'}, | |||
| event_name: str = 'event name', | |||
| json_file: Optional[str] = None, | |||
| json_thousands_separator: str = punctuation_space, | |||
There was a problem hiding this comment.
Unbound name: Name punctuation_space is used but not defined in the current scope.
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| commit='commit', | ||
| reference_type='type', reference_commit='ref' | ||
| ), | ||
| annotations=[Annotation( |
There was a problem hiding this comment.
Unbound name: Name Annotation is used but not defined in the current scope.
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| runs=9, runs_succ=10, runs_skip=11, runs_fail=12, runs_error=1345, | ||
| commit='commit' | ||
| ), | ||
| stats_with_delta=UnitTestRunDeltaResults( |
There was a problem hiding this comment.
Unbound name: Name UnitTestRunDeltaResults is used but not defined in the current scope.
(at-me in a reply with help or ignore)
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
This comment has been minimized.
This comment has been minimized.
Test Results (Test Files) 26 files ±0 4 errors 23 suites ±0 39m 21s ⏱️ ±0s For more details on these parsing errors, failures and errors, see this check. Results for commit 5c7a9f5. ± Comparison against base commit edf3cdc. ♻️ This comment has been updated with latest results. |
This comment has been minimized.
This comment has been minimized.
EnricoMi
force-pushed
the
branch-json-formatted
branch
from
ce707c8 to
6fc2a15
Compare
This comment has been minimized.
This comment has been minimized.
Fixes #282.