Log file sizes and free mem #305
Conversation
This comment has been minimized.
This comment has been minimized.
Test Results (Test Files) 26 files ±0 4 errors 23 suites ±0 39m 21s ⏱️ ±0s For more details on these parsing errors, failures and errors, see this check. Results for commit f28d9a8. ± Comparison against base commit 3281b65. ♻️ This comment has been updated with latest results. |
EnricoMi
force-pushed
the
branch-log-file-sizes
branch
from
2f697c0 to
9399470
Compare
This comment has been minimized.
This comment has been minimized.
EnricoMi
force-pushed
the
branch-log-file-sizes
branch
from
9399470 to
fef0c81
Compare
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| @@ -114,7 +120,7 @@ def parse(path: str) -> Union[str, Any]: | |||
| except BaseException as e: | |||
| return e | |||
|
|
|||
| parsed_files = [(result_file, parse(result_file)) | |||
| parsed_files = [progress((result_file, parse(result_file))) | |||
There was a problem hiding this comment.
Incompatible parameter type: Expected Variable[T] for 1st positional only parameter to anonymous call but got typing.Tuple[str, typing.Any].
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| progress = Progress(items) | ||
| plogger = ProgressLogger(progress, interval_seconds, progress_template, logger).start() | ||
| try: | ||
| yield progress.observe |
There was a problem hiding this comment.
Incompatible return type: Expected typing.Callable[[Variable[T]], Variable[T]] but got typing.Generator[BoundMethod[typing.Callable(Progress.observe)[[Named(self, Progress[typing.Any]), Named(observation, typing.Any)], typing.Any], Progress[typing.Any]], None, None].
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| @@ -114,7 +120,7 @@ def parse(path: str) -> Union[str, Any]: | |||
| except BaseException as e: | |||
| return e | |||
|
|
|||
| parsed_files = [(result_file, parse(result_file)) | |||
| parsed_files = [progress((result_file, parse(result_file))) | |||
| for result_file in files] | |||
| junits = [(result_file, junit) | |||
| for result_file, junit in parsed_files | |||
There was a problem hiding this comment.
Unable to unpack: Unable to unpack Variable[python.publish.junit.T] into 2 values.
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
python/publish/progress.py
Outdated
| interval_seconds: int, | ||
| progress_template: str, | ||
| finish_template: Optional[str], | ||
| logger: Logger) -> Callable[[T], T]: |
There was a problem hiding this comment.
Invalid type variable: The type variable Variable[T] isn't present in the function's parameters.
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
This comment has been minimized.
This comment has been minimized.
EnricoMi
force-pushed
the
branch-log-file-sizes
branch
from
fef0c81 to
4621b00
Compare
This comment has been minimized.
This comment has been minimized.
python/publish/progress.py
Outdated
| progress_template: str, | ||
| finish_template: Optional[str], | ||
| logger: Logger, | ||
| progress_item_type: Type[T] = Any) -> Callable[[Any], Any]: |
There was a problem hiding this comment.
Incompatible variable type: progress_item_type is declared to have type Type[Variable[T]] but is used as type object.
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| progress = Progress[progress_item_type](items) | ||
| plogger = ProgressLogger(progress, interval_seconds, progress_template, logger).start() | ||
| try: | ||
| yield progress.observe |
There was a problem hiding this comment.
Incompatible return type: Expected typing.Callable[[typing.Any], typing.Any] but got typing.Generator[BoundMethod[typing.Callable(Progress.observe)[[Named(self, Progress[Variable[T]]), Named(observation, Variable[T])], Variable[T]], Progress[Variable[T]]], None, None].
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
This comment has been minimized.
This comment has been minimized.
EnricoMi
force-pushed
the
branch-log-file-sizes
branch
from
8b23c9f to
f28d9a8
Compare
| progress = Progress[progress_item_type](items) | ||
| plogger = ProgressLogger(progress, interval_seconds, progress_template, logger).start() | ||
| try: | ||
| yield progress.observe |
There was a problem hiding this comment.
Incompatible return type: Expected typing.Callable[[Variable[T]], Variable[T]] but got typing.Generator[BoundMethod[typing.Callable(Progress.observe)[[Named(self, Progress[Variable[T]]), Named(observation, Variable[T])], Variable[T]], Progress[Variable[T]]], None, None].
Reply with "@sonatype-lift help" for more info.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
Logs the number of files to read and their size, the available memory, and logs progress every 10s.
Fixes #304.