Split cache step into two, always save cache, fix hash files #422

EnricoMi · 2023-03-14T13:14:47Z

No description provided.

github-actions · 2023-03-14T13:22:37Z

Test Results (setup-python)

      69 files ±0       69 suites ±0 29m 53s ⏱️ +55s
    405 tests ±0     405 ✔️ ±0     0 💤 ±0 0 ❌ ±0
27 945 runs ±0 27 405 ✔️ ±0 540 💤 ±0 0 ❌ ±0

Results for commit 3b245f4. ± Comparison against base commit 2c22e15.

♻️ This comment has been updated with latest results.

github-actions · 2023-03-14T13:22:45Z

Test Results (Test File)

97 tests ±0 80 ✔️ ±0 3m 25s ⏱️ ±0s
  1 suites ±0 17 💤 ±0
  1 files ±0   0 ❌ ±0

Results for commit 3b245f4. ± Comparison against base commit 2c22e15.

♻️ This comment has been updated with latest results.

github-actions · 2023-03-14T13:22:50Z

Test Results (Dockerfile)

      69 files ±0       69 suites ±0 29m 53s ⏱️ +55s
    405 tests ±0     405 ✔️ ±0     0 💤 ±0 0 ❌ ±0
27 945 runs ±0 27 405 ✔️ ±0 540 💤 ±0 0 ❌ ±0

Results for commit 3b245f4. ± Comparison against base commit 2c22e15.

♻️ This comment has been updated with latest results.

github-actions · 2023-03-14T13:22:54Z

Test Results (macOS python 3.8)

      69 files ±0       69 suites ±0 29m 53s ⏱️ +55s
    405 tests ±0     405 ✔️ ±0     0 💤 ±0 0 ❌ ±0
27 945 runs ±0 27 405 ✔️ ±0 540 💤 ±0 0 ❌ ±0

Results for commit 3b245f4. ± Comparison against base commit 2c22e15.

♻️ This comment has been updated with latest results.

TWiStErRob · 2023-03-14T13:22:54Z

composite/action.yml

+      uses: actions/cache/save@v3
+      if: always()


with this, you can essentially remove the date trick that accounts for #418 (comment), right?

github-actions · 2023-03-14T13:23:04Z

Test Results (Test Files)

  140 files ±0     10 errors 730 suites ±0 2h 12m 25s ⏱️ ±0s
1 786 tests ±0 1 499 ✔️ ±0   71 💤 ±0 208 ❌ ±0   8 🔥 ±0
4 092 runs ±0 3 410 ✔️ ±0 212 💤 ±0 452 ❌ ±0 18 🔥 ±0

For more details on these parsing errors, failures and errors, see this check.

Results for commit 3b245f4. ± Comparison against base commit 2c22e15.

♻️ This comment has been updated with latest results.

github-actions · 2023-03-14T13:23:16Z

Test Results (Docker Image)

      69 files ±0       69 suites ±0 29m 53s ⏱️ +55s
    405 tests ±0     405 ✔️ ±0     0 💤 ±0 0 ❌ ±0
27 945 runs ±0 27 405 ✔️ ±0 540 💤 ±0 0 ❌ ±0

Results for commit 3b245f4. ± Comparison against base commit 2c22e15.

♻️ This comment has been updated with latest results.

TWiStErRob · 2023-03-14T13:23:28Z

composite/action.yml

-      uses: actions/cache@v3
+    - name: Restore PIP packages cache
+      id: cache
+      uses: actions/cache/restore@v3


can I use this branch directly?

Let's see TWiStErRob/net.twisterrob.libraries@b66a8c6

uses: EnricoMi/publish-unit-test-result-action/composite@branch-composite-cache-pip-packages-2

I went for the direct hash, so it's clear which commit was used, but now I realize that "Set up job" lists them.

github-actions · 2023-03-14T13:23:53Z

Test Results (Linux python 3.8)

      69 files ±0       69 suites ±0 29m 53s ⏱️ +55s
    405 tests ±0     405 ✔️ ±0     0 💤 ±0 0 ❌ ±0
27 945 runs ±0 27 405 ✔️ ±0 540 💤 ±0 0 ❌ ±0

Results for commit 3b245f4. ± Comparison against base commit 2c22e15.

♻️ This comment has been updated with latest results.

github-actions · 2023-03-14T13:24:52Z

Test Results (Linux python installed)

      69 files ±0       69 suites ±0 29m 53s ⏱️ +55s
    405 tests ±0     405 ✔️ ±0     0 💤 ±0 0 ❌ ±0
27 945 runs ±0 27 405 ✔️ ±0 540 💤 ±0 0 ❌ ±0

Results for commit 3b245f4. ± Comparison against base commit 2c22e15.

♻️ This comment has been updated with latest results.

github-actions · 2023-03-14T13:25:30Z

Test Results (macOS 12 python installed)

      69 files ±0       69 suites ±0 29m 53s ⏱️ +55s
    405 tests ±0     405 ✔️ ±0     0 💤 ±0 0 ❌ ±0
27 945 runs ±0 27 405 ✔️ ±0 540 💤 ±0 0 ❌ ±0

Results for commit 3b245f4. ± Comparison against base commit 2c22e15.

♻️ This comment has been updated with latest results.

github-actions · 2023-03-14T13:25:32Z

Test Results (Linux 22.04 python installed)

      69 files ±0       69 suites ±0 29m 53s ⏱️ +55s
    405 tests ±0     405 ✔️ ±0     0 💤 ±0 0 ❌ ±0
27 945 runs ±0 27 405 ✔️ ±0 540 💤 ±0 0 ❌ ±0

Results for commit 3b245f4. ± Comparison against base commit 2c22e15.

♻️ This comment has been updated with latest results.

github-actions · 2023-03-14T13:26:24Z

Test Results (macOS python installed)

      69 files ±0       69 suites ±0 29m 53s ⏱️ +55s
    405 tests ±0     405 ✔️ ±0     0 💤 ±0 0 ❌ ±0
27 945 runs ±0 27 405 ✔️ ±0 540 💤 ±0 0 ❌ ±0

Results for commit 3b245f4. ± Comparison against base commit 2c22e15.

♻️ This comment has been updated with latest results.

github-actions · 2023-03-14T13:27:20Z

Test Results (Windows python installed)

      69 files ±0       69 suites ±0 29m 53s ⏱️ +55s
    405 tests ±0     405 ✔️ ±0     0 💤 ±0 0 ❌ ±0
27 945 runs ±0 27 405 ✔️ ±0 540 💤 ±0 0 ❌ ±0

Results for commit 3b245f4. ± Comparison against base commit 2c22e15.

♻️ This comment has been updated with latest results.

TWiStErRob · 2023-03-14T13:27:50Z

composite/action.yml

@@ -238,6 +239,14 @@ runs:
        LOG_LEVEL: ${{ inputs.log_level }}
      shell: bash

+    - name: Save PIP packages cache
+      uses: actions/cache/save@v3
+      if: always()


if: success() || failure()

always() includes cancelled() which might result in a partial broken cache

https://docs.github.com/en/actions/learn-github-actions/expressions#status-check-functions

A timeout can easily happen on tests, in which case an empty cache might over-write pip cache. Or the timeout happens while the pip is running which results in bad state.

github-actions · 2023-03-14T13:29:18Z

Test Results (reference)

      69 files ±0       69 suites ±0 29m 53s ⏱️ +55s
    405 tests ±0     405 ✔️ ±0     0 💤 ±0 0 ❌ ±0
27 945 runs ±0 27 405 ✔️ ±0 540 💤 ±0 0 ❌ ±0

Results for commit 3b245f4. ± Comparison against base commit 2c22e15.

♻️ This comment has been updated with latest results.

TWiStErRob · 2023-03-14T17:03:43Z

Please let me know if I should re-run on latest of this PR. Also please see the comments in this PR, they might be hiding between the test results.

This reverts commit f3d26d2.

EnricoMi · 2023-03-15T17:36:23Z

@TWiStErRob go for it, please test this branch!

TWiStErRob · 2023-03-15T17:38:52Z

Queued https://github.com/TWiStErRob/net.twisterrob.libraries/actions/runs/4416412575/jobs/7769498594 - 20-30 minutes.

TWiStErRob · 2023-03-15T18:01:26Z

😍

TWiStErRob · 2023-03-15T18:27:55Z

I reran it just to try and it took more than a minute second time:
https://github.com/TWiStErRob/net.twisterrob.libraries/actions/runs/4416412575/attempts/4

Both times it restored caches.
I cleared caches and running it again:
https://github.com/TWiStErRob/net.twisterrob.libraries/actions/runs/4416412575/attempts/5 (cancelled)
and will run again when it finishes to see the cache-reuse.

EnricoMi · 2023-03-15T18:28:34Z

Can you rerun the 🧪 Instrumentation Tests on 21 job, please? There is still an issue with the cache key.

TWiStErRob · 2023-03-15T18:32:25Z

Cancelled and running again with latest: https://github.com/TWiStErRob/net.twisterrob.libraries/actions/runs/4416412575/attempts/6
invited you, feel free to edit the branch and run the CI directly on TWiStErRob/net.twisterrob.libraries#38

EnricoMi · 2023-03-15T18:33:33Z

invited you

Thanks!

TWiStErRob · 2023-03-15T18:38:13Z

Sorry, cancelled again, hopefully reduced CI time significantly by running less tests.

EnricoMi · 2023-03-16T17:05:33Z

Run with cache miss:
https://github.com/TWiStErRob/net.twisterrob.libraries/actions/runs/4429767427/jobs/7790625895#step:6:92

Run with cache hit:
https://github.com/TWiStErRob/net.twisterrob.libraries/actions/runs/4429767427/jobs/7791493539#step:6:96

TWiStErRob · 2023-03-16T17:09:18Z

composite/action.yml

      continue-on-error: true
      with:
        path: ${{ steps.os.outputs.pip-cache }}
-        key: enricomi-publish-action-${{ runner.os }}-${{ runner.arch }}-pip-${{ steps.python.outputs.version }}-${{ hashFiles('**/requirements.txt', 'composite/action.yml') }}
+        key: enricomi-publish-action-${{ runner.os }}-${{ runner.arch }}-pip-${{ steps.python.outputs.version }}-f3f2c295046c91ed612b4efb6c9fb352

    - name: Install Python dependencies


Can this affect steps.python.outputs.version, so that when it comes to cache/save it's a different version but it's still using the old key?

Don't get it. With key: ${{ steps.cache.outputs.cache-primary-key }}, the same key is used when saving the cache. Why should the python version change?

TWiStErRob · 2023-03-16T17:09:52Z

composite/action.yml

      continue-on-error: true
      with:
        path: ${{ steps.os.outputs.pip-cache }}
-        key: enricomi-publish-action-${{ runner.os }}-${{ runner.arch }}-pip-${{ steps.python.outputs.version }}-${{ hashFiles('**/requirements.txt', 'composite/action.yml') }}
+        key: enricomi-publish-action-${{ runner.os }}-${{ runner.arch }}-pip-${{ steps.python.outputs.version }}-f3f2c295046c91ed612b4efb6c9fb352


I saw you were fighting with this, in the end you'll update it manually for each release?

Could you pull in https://github.com/actions/github-script and call hashFiles directly from JS?

it's in glob: https://github.com/actions/toolkit/blob/main/packages/glob/src/glob.ts#L29

you'll update it manually for each release

yes, but only if requirements.txt changes

and call hashFiles directly from JS?

maybe, but I'd prefer not to add more complexity

TWiStErRob · 2023-03-16T17:11:25Z

Amazing! Congrats, it looked like a very hard labor. It's funny how 15MB can cut 3.5min to 15 seconds

EnricoMi · 2023-03-16T18:11:00Z

Found two bugs or undocumented edge cases where hashFiles does not work. With . or .. in the path parsing the yaml fails, and files in some paths are not reachable. Very annoying.

Split cache step into two, always save cache

b1e5358

EnricoMi mentioned this pull request Mar 14, 2023

Add pip cache to composite action #411

Closed

TWiStErRob reviewed Mar 14, 2023

View reviewed changes

EnricoMi added 3 commits March 14, 2023 14:29

Save only on cache-miss

b2f032e

Use path to composite action to hash files

2b6fa8a

Reduce test space to speedup testing

f3d26d2

EnricoMi force-pushed the branch-composite-cache-pip-packages-2 branch from 6df3e74 to f3d26d2 Compare March 14, 2023 13:58

EnricoMi changed the title ~~Split cache step into two, always save cache~~ Split cache step into two, always save cache, fix hash files Mar 14, 2023

EnricoMi force-pushed the branch-composite-cache-pip-packages-2 branch 4 times, most recently from 463c81c to 8501241 Compare March 14, 2023 16:49

Fix path to hash files

39cb97a

EnricoMi force-pushed the branch-composite-cache-pip-packages-2 branch from 8501241 to 39cb97a Compare March 14, 2023 17:15

EnricoMi added 4 commits March 15, 2023 11:13

Parent dir .. is not allowed in hashFiles

8ca89f3

hashFiles does not like . either

dea52ad

Revert "Reduce test space to speedup testing"

c716610

This reverts commit f3d26d2.

Save cache on success and failure, not always

7dd29b2

Debug env

9f16304

List action path

5caa817

EnricoMi added 2 commits March 16, 2023 15:25

Debug hashed files

f5f5603

Debug hash

1781604

EnricoMi force-pushed the branch-composite-cache-pip-packages-2 branch from 8530724 to 1781604 Compare March 16, 2023 14:33

EnricoMi added 3 commits March 16, 2023 15:40

More debug

b33cf99

Scratch hashFiles, does not work for file in composite action path

5051b23

Check cache hash is up-to-date in unit test

7b55088

EnricoMi force-pushed the branch-composite-cache-pip-packages-2 branch from d5f8056 to 7b55088 Compare March 16, 2023 15:20

TWiStErRob reviewed Mar 16, 2023

View reviewed changes

Skip the cache hash check on Windows

3b245f4

EnricoMi merged commit acf931c into master Mar 16, 2023

EnricoMi deleted the branch-composite-cache-pip-packages-2 branch March 16, 2023 18:15

TWiStErRob mentioned this pull request Mar 21, 2023

Test UI test results publishing composite caching TWiStErRob/net.twisterrob.libraries#38

Closed

Split cache step into two, always save cache, fix hash files #422

Split cache step into two, always save cache, fix hash files #422

Conversation

EnricoMi commented Mar 14, 2023

github-actions bot commented Mar 14, 2023 • edited Loading

Test Results (setup-python)

github-actions bot commented Mar 14, 2023 • edited Loading

Test Results (Test File)

github-actions bot commented Mar 14, 2023 • edited Loading

Test Results (Dockerfile)

github-actions bot commented Mar 14, 2023 • edited Loading

Test Results (macOS python 3.8)

Choose a reason for hiding this comment

github-actions bot commented Mar 14, 2023 • edited Loading

Test Results (Test Files)

github-actions bot commented Mar 14, 2023 • edited Loading

Test Results (Docker Image)

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Mar 14, 2023 • edited Loading

Test Results (Linux python 3.8)

github-actions bot commented Mar 14, 2023 • edited Loading

Test Results (Linux python installed)

github-actions bot commented Mar 14, 2023 • edited Loading

Test Results (macOS 12 python installed)

github-actions bot commented Mar 14, 2023 • edited Loading

Test Results (Linux 22.04 python installed)

github-actions bot commented Mar 14, 2023 • edited Loading

Test Results (macOS python installed)

github-actions bot commented Mar 14, 2023 • edited Loading

Test Results (Windows python installed)

TWiStErRob Mar 14, 2023 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Mar 14, 2023 • edited Loading

Test Results (reference)

TWiStErRob commented Mar 14, 2023

EnricoMi commented Mar 15, 2023

TWiStErRob commented Mar 15, 2023 • edited Loading

TWiStErRob commented Mar 15, 2023

TWiStErRob commented Mar 15, 2023 • edited Loading

EnricoMi commented Mar 15, 2023

TWiStErRob commented Mar 15, 2023

EnricoMi commented Mar 15, 2023

TWiStErRob commented Mar 15, 2023

EnricoMi commented Mar 16, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TWiStErRob commented Mar 16, 2023

EnricoMi commented Mar 16, 2023

github-actions bot commented Mar 14, 2023 •

edited

Loading

github-actions bot commented Mar 14, 2023 •

edited

Loading

github-actions bot commented Mar 14, 2023 •

edited

Loading

github-actions bot commented Mar 14, 2023 •

edited

Loading

github-actions bot commented Mar 14, 2023 •

edited

Loading

github-actions bot commented Mar 14, 2023 •

edited

Loading

github-actions bot commented Mar 14, 2023 •

edited

Loading

github-actions bot commented Mar 14, 2023 •

edited

Loading

github-actions bot commented Mar 14, 2023 •

edited

Loading

github-actions bot commented Mar 14, 2023 •

edited

Loading

github-actions bot commented Mar 14, 2023 •

edited

Loading

github-actions bot commented Mar 14, 2023 •

edited

Loading

TWiStErRob Mar 14, 2023 •

edited

Loading

github-actions bot commented Mar 14, 2023 •

edited

Loading

TWiStErRob commented Mar 15, 2023 •

edited

Loading

TWiStErRob commented Mar 15, 2023 •

edited

Loading