Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option comment_on_pr #47

Merged
merged 6 commits into from
Nov 2, 2020
Merged

Add option comment_on_pr #47

merged 6 commits into from
Nov 2, 2020

Conversation

efaulhaber
Copy link
Contributor

Resolves #37.

@github-actions

This comment has been minimized.

Sign in to view
@efaulhaber
Copy link
Contributor Author

I tested and commented the results in efaulhaber#3.

EnricoMi
EnricoMi requested changes Nov 2, 2020
View reviewed changes
Copy link
Owner

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, looks good. Only minor change requests.

publish_unit_test_results.py Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

Sign in to view
@efaulhaber efaulhaber requested a review from EnricoMi November 2, 2020 09:26
EnricoMi
EnricoMi approved these changes Nov 2, 2020
View reviewed changes
Copy link
Owner

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@EnricoMi EnricoMi merged commit f8a3fca into EnricoMi:master Nov 2, 2020
@github-actions
Copy link

github-actions bot commented Nov 2, 2020

Unit Test Results

  1 files  ±0    1 suites  ±0   0s ⏱️ ±0s
24 tests ±0  24 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

results for commit f8a3fca ± comparison against base commit 9b704f6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EnricoMi EnricoMi EnricoMi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable commenting on Pull Requests
2 participants
@efaulhaber @EnricoMi