Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote python bin in windows bash action #587

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

EnricoMi
Copy link
Owner

@EnricoMi EnricoMi commented Mar 21, 2024

In #585 the python bin got unquoted, leading to #586:

PYTHON_VERSION="$($PYTHON_BIN -c 'import sys; print(f"{sys.version_info.major}.{sys.version_info.minor}")')"

Fixes #586.

@EnricoMi EnricoMi mentioned this pull request Mar 21, 2024
Copy link

Test Results (Linux python venv)

   147 files  ±0     147 suites  ±0   47m 33s ⏱️ + 3m 23s
   438 tests ±0     438 ✅ ±0      0 💤 ±0  0 ❌ ±0 
64 386 runs  ±0  62 874 ✅ ±0  1 512 💤 ±0  0 ❌ ±0 

Results for commit 70aa855. ± Comparison against base commit b25bb15.

Copy link

Test Results (Linux python 3.8)

   147 files  ±0     147 suites  ±0   47m 33s ⏱️ + 3m 23s
   438 tests ±0     438 ✅ ±0      0 💤 ±0  0 ❌ ±0 
64 386 runs  ±0  62 874 ✅ ±0  1 512 💤 ±0  0 ❌ ±0 

Results for commit 70aa855. ± Comparison against base commit b25bb15.

Copy link

Test Results (macOS python venv)

   147 files  ±0     147 suites  ±0   47m 33s ⏱️ + 3m 23s
   438 tests ±0     438 ✅ ±0      0 💤 ±0  0 ❌ ±0 
64 386 runs  ±0  62 874 ✅ ±0  1 512 💤 ±0  0 ❌ ±0 

Results for commit 70aa855. ± Comparison against base commit b25bb15.

Copy link

Test Results (macOS python 3.8)

   147 files  ±0     147 suites  ±0   47m 33s ⏱️ + 3m 23s
   438 tests ±0     438 ✅ ±0      0 💤 ±0  0 ❌ ±0 
64 386 runs  ±0  62 874 ✅ ±0  1 512 💤 ±0  0 ❌ ±0 

Results for commit 70aa855. ± Comparison against base commit b25bb15.

Copy link

Test Results (Test File)

97 tests  ±0   80 ✅ ±0   3m 25s ⏱️ ±0s
 1 suites ±0   17 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 70aa855. ± Comparison against base commit b25bb15.

Copy link

Test Results (Dockerfile)

   147 files  ±0     147 suites  ±0   47m 33s ⏱️ + 3m 23s
   438 tests ±0     438 ✅ ±0      0 💤 ±0  0 ❌ ±0 
64 386 runs  ±0  62 874 ✅ ±0  1 512 💤 ±0  0 ❌ ±0 

Results for commit 70aa855. ± Comparison against base commit b25bb15.

Copy link

Test Results (Test Files)

  214 files  ±0     86 errors  731 suites  ±0   2h 12m 36s ⏱️ ±0s
1 811 tests ±0  1 518 ✅ ±0   73 💤 ±0  209 ❌ ±0  11 🔥 ±0 
4 109 runs  ±0  3 424 ✅ ±0  214 💤 ±0  450 ❌ ±0  21 🔥 ±0 

For more details on these parsing errors, failures and errors, see this check.

Results for commit 70aa855. ± Comparison against base commit b25bb15.

Copy link

Test Results (macOS composite python )

   147 files  ±0     147 suites  ±0   47m 33s ⏱️ + 3m 23s
   438 tests ±0     438 ✅ ±0      0 💤 ±0  0 ❌ ±0 
64 386 runs  ±0  62 874 ✅ ±0  1 512 💤 ±0  0 ❌ ±0 

Results for commit 70aa855. ± Comparison against base commit b25bb15.

Copy link

Test Results (Windows python venv)

   147 files  ±0     147 suites  ±0   47m 33s ⏱️ + 3m 23s
   438 tests ±0     438 ✅ ±0      0 💤 ±0  0 ❌ ±0 
64 386 runs  ±0  62 874 ✅ ±0  1 512 💤 ±0  0 ❌ ±0 

Results for commit 70aa855. ± Comparison against base commit b25bb15.

Copy link

Test Results (Docker Image amd64)

   147 files  ±0     147 suites  ±0   47m 33s ⏱️ + 3m 23s
   438 tests ±0     438 ✅ ±0      0 💤 ±0  0 ❌ ±0 
64 386 runs  ±0  62 874 ✅ ±0  1 512 💤 ±0  0 ❌ ±0 

Results for commit 70aa855. ± Comparison against base commit b25bb15.

Copy link

Test Results (Windows python installed)

   147 files  ±0     147 suites  ±0   47m 33s ⏱️ + 3m 23s
   438 tests ±0     438 ✅ ±0      0 💤 ±0  0 ❌ ±0 
64 386 runs  ±0  62 874 ✅ ±0  1 512 💤 ±0  0 ❌ ±0 

Results for commit 70aa855. ± Comparison against base commit b25bb15.

Copy link

Test Results (Linux python installed)

   147 files  ±0     147 suites  ±0   47m 33s ⏱️ + 3m 23s
   438 tests ±0     438 ✅ ±0      0 💤 ±0  0 ❌ ±0 
64 386 runs  ±0  62 874 ✅ ±0  1 512 💤 ±0  0 ❌ ±0 

Results for commit 70aa855. ± Comparison against base commit b25bb15.

Copy link

Test Results (Linux 20.04 python installed)

   147 files  ±0     147 suites  ±0   47m 33s ⏱️ + 3m 23s
   438 tests ±0     438 ✅ ±0      0 💤 ±0  0 ❌ ±0 
64 386 runs  ±0  62 874 ✅ ±0  1 512 💤 ±0  0 ❌ ±0 

Results for commit 70aa855. ± Comparison against base commit b25bb15.

Copy link

Test Results (Windows bash python venv)

   147 files  ±0     147 suites  ±0   47m 33s ⏱️ + 3m 23s
   438 tests ±0     438 ✅ ±0      0 💤 ±0  0 ❌ ±0 
64 386 runs  ±0  62 874 ✅ ±0  1 512 💤 ±0  0 ❌ ±0 

Results for commit 70aa855. ± Comparison against base commit b25bb15.

Copy link

Test Results (Windows bash python installed)

   147 files  ±0     147 suites  ±0   47m 33s ⏱️ + 3m 23s
   438 tests ±0     438 ✅ ±0      0 💤 ±0  0 ❌ ±0 
64 386 runs  ±0  62 874 ✅ ±0  1 512 💤 ±0  0 ❌ ±0 

Results for commit 70aa855. ± Comparison against base commit b25bb15.

Copy link

Test Results (macOS python installed)

   147 files  ±0     147 suites  ±0   47m 33s ⏱️ + 3m 23s
   438 tests ±0     438 ✅ ±0      0 💤 ±0  0 ❌ ±0 
64 386 runs  ±0  62 874 ✅ ±0  1 512 💤 ±0  0 ❌ ±0 

Results for commit 70aa855. ± Comparison against base commit b25bb15.

Copy link

Test Results (Linux composite python )

   147 files  ±0     147 suites  ±0   47m 33s ⏱️ + 3m 23s
   438 tests ±0     438 ✅ ±0      0 💤 ±0  0 ❌ ±0 
64 386 runs  ±0  62 874 ✅ ±0  1 512 💤 ±0  0 ❌ ±0 

Results for commit 70aa855. ± Comparison against base commit b25bb15.

Copy link

Test Results (macOS 11 python installed)

   147 files  ±0     147 suites  ±0   47m 33s ⏱️ + 3m 23s
   438 tests ±0     438 ✅ ±0      0 💤 ±0  0 ❌ ±0 
64 386 runs  ±0  62 874 ✅ ±0  1 512 💤 ±0  0 ❌ ±0 

Results for commit 70aa855. ± Comparison against base commit b25bb15.

Copy link

Test Results (macOS 13 python installed)

   147 files  ±0     147 suites  ±0   47m 33s ⏱️ + 3m 23s
   438 tests ±0     438 ✅ ±0      0 💤 ±0  0 ❌ ±0 
64 386 runs  ±0  62 874 ✅ ±0  1 512 💤 ±0  0 ❌ ±0 

Results for commit 70aa855. ± Comparison against base commit b25bb15.

Copy link

Test Results (Windows 2019 python installed)

   147 files  ±0     147 suites  ±0   47m 33s ⏱️ + 3m 23s
   438 tests ±0     438 ✅ ±0      0 💤 ±0  0 ❌ ±0 
64 386 runs  ±0  62 874 ✅ ±0  1 512 💤 ±0  0 ❌ ±0 

Results for commit 70aa855. ± Comparison against base commit b25bb15.

Copy link

Test Results (Windows 2019 bash python installed)

   147 files  ±0     147 suites  ±0   47m 33s ⏱️ + 3m 23s
   438 tests ±0     438 ✅ ±0      0 💤 ±0  0 ❌ ±0 
64 386 runs  ±0  62 874 ✅ ±0  1 512 💤 ±0  0 ❌ ±0 

Results for commit 70aa855. ± Comparison against base commit b25bb15.

Copy link

Test Results (macOS 14 python installed)

   147 files  ±0     147 suites  ±0   47m 33s ⏱️ + 3m 23s
   438 tests ±0     438 ✅ ±0      0 💤 ±0  0 ❌ ±0 
64 386 runs  ±0  62 874 ✅ ±0  1 512 💤 ±0  0 ❌ ±0 

Results for commit 70aa855. ± Comparison against base commit b25bb15.

Copy link

Test Results (Windows composite python )

   147 files  ±0     147 suites  ±0   47m 33s ⏱️ + 3m 23s
   438 tests ±0     438 ✅ ±0      0 💤 ±0  0 ❌ ±0 
64 386 runs  ±0  62 874 ✅ ±0  1 512 💤 ±0  0 ❌ ±0 

Results for commit 70aa855. ± Comparison against base commit b25bb15.

Copy link

Test Results (Docker Image arm64)

   147 files  ±0     147 suites  ±0   47m 33s ⏱️ + 3m 23s
   438 tests ±0     438 ✅ ±0      0 💤 ±0  0 ❌ ±0 
64 386 runs  ±0  62 874 ✅ ±0  1 512 💤 ±0  0 ❌ ±0 

Results for commit 70aa855. ± Comparison against base commit b25bb15.

Copy link

Test Results (reference)

   147 files  ±0     147 suites  ±0   47m 33s ⏱️ + 3m 23s
   438 tests ±0     438 ✅ ±0      0 💤 ±0  0 ❌ ±0 
64 386 runs  ±0  62 874 ✅ ±0  1 512 💤 ±0  0 ❌ ±0 

Results for commit 70aa855. ± Comparison against base commit b25bb15.

@EnricoMi EnricoMi merged commit fbe9920 into master Mar 21, 2024
102 checks passed
@EnricoMi EnricoMi deleted the win-bash-fix-python-bin-quote branch March 21, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.16.0 syntax error
1 participant