feat(router-store): Make usage of forRoot required (ngrx#1662)

EnricoVogt · Mar 31, 2019 · ae28589 · ae28589
1 parent 78e237c
commit ae28589
Showing 1 changed file with 7 additions and 18 deletions.
diff --git a/modules/router-store/src/router_store_module.ts b/modules/router-store/src/router_store_module.ts
@@ -122,31 +122,15 @@ enum RouterTrigger {
  *       { path: '', component: SimpleCmp },
  *       { path: 'next', component: SimpleCmp }
  *     ]),
- *     StoreRouterConnectingModule
+ *     StoreRouterConnectingModule.forRoot()
  *   ],
  *   bootstrap: [AppCmp]
  * })
  * export class AppModule {
  * }
  * ```
  */
-@NgModule({
-  providers: [
-    {
-      provide: _ROUTER_CONFIG,
-      useValue: {},
-    },
-    {
-      provide: ROUTER_CONFIG,
-      useFactory: _createRouterConfig,
-      deps: [_ROUTER_CONFIG],
-    },
-    {
-      provide: RouterStateSerializer,
-      useClass: DefaultRouterStateSerializer,
-    },
-  ],
-})
+@NgModule()
 export class StoreRouterConnectingModule {
   static forRoot<
     T extends BaseRouterStoreState = SerializedRouterStateSnapshot
@@ -157,6 +141,11 @@ export class StoreRouterConnectingModule {
       ngModule: StoreRouterConnectingModule,
       providers: [
         { provide: _ROUTER_CONFIG, useValue: config },
+        {
+          provide: ROUTER_CONFIG,
+          useFactory: _createRouterConfig,
+          deps: [_ROUTER_CONFIG],
+        },
         {
           provide: RouterStateSerializer,
           useClass: config.serializer