Add some tests for manifest deploy part of odo deploy command
#13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steven Groeger <groeges@uk.ibm.com>
EnriqueL8
reviewed
Jul 1, 2020
| err := helper.ReplaceDevfileField("devfile.yaml", "alpha.deployment-manifest", "http://github.com/myfile.yaml") | ||
| Expect(err).To(BeNil()) | ||
|
|
||
| cmdOutput := helper.CmdShouldFail("odo", "deploy", "--tag", imageTag, "--deployOnly") |
There was a problem hiding this comment.
We need to remove this deployOnly since we haven't discussed it in the proposal
There was a problem hiding this comment.
Removed from tests. New PR will be raised to remove from actual ODO code.
| "https://raw.githubusercontent.com/groeges/devfile-registry/master/devfiles/nodejs/deploy_deployment.yaml") | ||
| Expect(err).To(BeNil()) | ||
|
|
||
| cmdOutput := helper.CmdShouldPass("odo", "deploy", "--tag", imageTag) |
There was a problem hiding this comment.
Enhancement for future PR?: We may want to verify that the deployment/service/route are created in this namespace.
Signed-off-by: Steven Groeger <groeges@uk.ibm.com>
EnriqueL8
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steven Groeger groeges@uk.ibm.com
What type of PR is this?
/kind cleanup
What does does this PR do / why we need it:
Adds some tests for the manifest deployment part of the
odo deploycommandWhich issue(s) this PR fixes:
Fixes #?
How to test changes / Special notes to the reviewer: