-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #1105
Merged
Merged
Update dependencies #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azangru
force-pushed
the
update-dependencies
branch
from
April 15, 2024 09:17
37fca79
to
92dbe0f
Compare
imransl
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Routine dependencies update
Noteworthy updates
Notes
- 1 -
There was an error with react override when updating Storybook.
npm ERR! Unable to resolve reference $react
Q: Why do we override react?
A: Because the officially released stable version of React (v. 18.2; more than a year and a half old by now) was spamming Sentry with hydration errors caused by script injection via chrome extensions (e.g. React dev tools). See #958 for details.
Changes made in this PR: changed the value in the overrides to the exact react version rather than the reference to react:
Before:
Now:
This is slightly worse practice, according to npm docs; but still in the "good" category:
I expect we will be able to remove the override once React 19 is officially out.
- 2 -
css-loader
has been updated from version 6 to version 7. There was a breaking change in version 7 in how css modules are created. Previously, when a CSS file was imported as a CSS module, it was treated as if it had a default export. Now, the default behaviour is to treat a css module as if each class were an independent named export (see link).For this PR, I updated webpack configs, adding css-loader options that override the new default behaviour to simulate the old one.
Possibly in a different PR
https://github.com/facebook/react/pull/28773
to be merged.Deployment URL(s)
http://update-dependencies.review.ensembl.org
Checks